github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5932] [PM-26095] Add account selection screen for Credential Exchange #6162

New Issue
Closed
opened 2025-11-27 00:20:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:20:27 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/5932

State: closed
Merged: Yes

🎟️ Tracking

PM-26095

📔 Objective

This commit introduces a new screen that allows users to select an account when importing items via the Credential Exchange Framework (CXF).

When a Credential Exchange import request is received the user is prompted to confirm which account to export items from.

Should the user choose to close the screen, the export process will be cancelled and the user returned to the requesting application.

Key changes include:

  • Added SelectAccountScreen.kt for the UI of the account selection.
  • Added SelectAccountViewModel.kt to manage the state and logic for account selection.
  • Included AccountSelectionListItem.kt to model the items displayed in the account list.
  • Implemented SelectAccountHandlers.kt to manage user interactions on the screen.
  • Added unit tests for the new screen (SelectAccountScreenTest.kt) and view model (SelectAccountViewModelTest.kt).
  • Added new string resources for the account selection screen.
  • Updated BitwardenComposeTest.kt and LocalManagerProvider.kt to include CredentialExchangeCompletionManager.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/5932 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-26095 ## 📔 Objective This commit introduces a new screen that allows users to select an account when importing items via the Credential Exchange Framework (CXF). When a Credential Exchange import request is received the user is prompted to confirm which account to export items from. Should the user choose to close the screen, the export process will be cancelled and the user returned to the requesting application. Key changes include: - Added `SelectAccountScreen.kt` for the UI of the account selection. - Added `SelectAccountViewModel.kt` to manage the state and logic for account selection. - Included `AccountSelectionListItem.kt` to model the items displayed in the account list. - Implemented `SelectAccountHandlers.kt` to manage user interactions on the screen. - Added unit tests for the new screen (`SelectAccountScreenTest.kt`) and view model (`SelectAccountViewModelTest.kt`). - Added new string resources for the account selection screen. - Updated `BitwardenComposeTest.kt` and `LocalManagerProvider.kt` to include `CredentialExchangeCompletionManager`. ## 📸 Screenshots <img width="365" alt="image" src="https://github.com/user-attachments/assets/4db5d6cb-3710-44b8-8dfe-14740fcc9ee6" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:20:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?