github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #3003] [MERGED] Version Bump workflow - Fix while loop #61217

New Issue
Closed
opened 2026-05-12 00:29:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-12 00:29:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3003
Author: @vgrassia
Created: 2/12/2024
Status: ✅ Merged
Merged: 2/12/2024
Merged by: @vgrassia

Base: main ← Head: fix-while-loop-version-bump

📝 Commits (1)

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 .github/workflows/version-bump.yml (+5 -2)

📄 Description

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR fixes a syntax error in the while loop for checking if the versions have been updated. I have tested this bit of code locally and it now works properly.

Code changes

  • .github/workflows/version-bump.yml: Update back to a while..do loop with proper syntax.

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3003 **Author:** [@vgrassia](https://github.com/vgrassia) **Created:** 2/12/2024 **Status:** ✅ Merged **Merged:** 2/12/2024 **Merged by:** [@vgrassia](https://github.com/vgrassia) **Base:** `main` ← **Head:** `fix-while-loop-version-bump` --- ### 📝 Commits (1) - [`8a6be1c`](https://github.com/bitwarden/android/commit/8a6be1c352a89a680c60187c13dd8a0eb67f5159) Fix while loop ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/version-bump.yml` (+5 -2) </details> ### 📄 Description ## Type of change <!-- (mark with an `X`) --> ``` - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR fixes a syntax error in the `while` loop for checking if the versions have been updated. I have tested this bit of code locally and it now works properly. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - **.github/workflows/version-bump.yml:** Update back to a `while..do` loop with proper syntax. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team - Ensure that all UI additions follow [WCAG AA requirements](https://contributing.bitwarden.com/contributing/accessibility/) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-12 00:29:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#61217
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?