github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5872] [PM-25664] Add CredentialExchangeImportManager for CXF payload import #6111

New Issue
Closed
opened 2025-11-27 00:19:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:19:53 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/5872

State: closed
Merged: Yes

🎟️ Tracking

PM-25664

📔 Objective

This change introduces a CredentialExchangeImportManager to handle the logic for importing CXF payloads. The VaultRepositoryImpl now delegates CXF import operations to this new manager.

Key changes:

  • Created CredentialExchangeImportManager interface and its implementation CredentialExchangeImportManagerImpl.
  • CredentialExchangeImportManagerImpl now handles the direct interaction with VaultSdkSource for CXF import and CiphersService for uploading ciphers.
  • VaultRepositoryImpl.importCxfPayload now uses CredentialExchangeImportManager and syncs the vault after a successful import.
  • Renamed ImportCxfPayloadResult (repository model) to ImportCxfPayloadResult (manager model) and updated its structure.
  • Introduced a new ImportCredentialsResult sealed class in the repository model to represent the outcome of the import and subsequent sync.
  • Added corresponding tests for CredentialExchangeImportManagerImpl.
  • Updated VaultRepositoryTest to reflect the changes in import logic and result types.
  • Included necessary dependencies for AndroidX Credentials.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/5872 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-25664 ## 📔 Objective This change introduces a `CredentialExchangeImportManager` to handle the logic for importing CXF payloads. The `VaultRepositoryImpl` now delegates CXF import operations to this new manager. Key changes: - Created `CredentialExchangeImportManager` interface and its implementation `CredentialExchangeImportManagerImpl`. - `CredentialExchangeImportManagerImpl` now handles the direct interaction with `VaultSdkSource` for CXF import and `CiphersService` for uploading ciphers. - `VaultRepositoryImpl.importCxfPayload` now uses `CredentialExchangeImportManager` and syncs the vault after a successful import. - Renamed `ImportCxfPayloadResult` (repository model) to `ImportCxfPayloadResult` (manager model) and updated its structure. - Introduced a new `ImportCredentialsResult` sealed class in the repository model to represent the outcome of the import and subsequent sync. - Added corresponding tests for `CredentialExchangeImportManagerImpl`. - Updated `VaultRepositoryTest` to reflect the changes in import logic and result types. - Included necessary dependencies for AndroidX Credentials. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:19:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6111
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?