github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5871] Refactor Vault Sync Logic into VaultSyncManager #6110

New Issue
Closed
opened 2025-11-27 00:19:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:19:53 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/5871

State: closed
Merged: Yes

🎟️ Tracking

TBD

📔 Objective

This change introduces VaultSyncManager to encapsulate the vault synchronization logic previously handled within VaultRepositoryImpl.

Key changes:

  • Created VaultSyncManager interface and VaultSyncManagerImpl implementation.
  • Moved sync-related logic, including security stamp checks, organization crypto initialization, and data storage, from VaultRepositoryImpl to VaultSyncManagerImpl.
  • VaultRepositoryImpl now delegates sync operations to VaultSyncManager.
  • Introduced SecurityStampMismatchException for clearer error handling.
  • Moved SyncVaultDataResult to com.x8bit.bitwarden.data.vault.manager.model.
  • Updated DI modules and tests to reflect these changes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/5871 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking TBD ## 📔 Objective This change introduces `VaultSyncManager` to encapsulate the vault synchronization logic previously handled within `VaultRepositoryImpl`. Key changes: - Created `VaultSyncManager` interface and `VaultSyncManagerImpl` implementation. - Moved sync-related logic, including security stamp checks, organization crypto initialization, and data storage, from `VaultRepositoryImpl` to `VaultSyncManagerImpl`. - `VaultRepositoryImpl` now delegates sync operations to `VaultSyncManager`. - Introduced `SecurityStampMismatchException` for clearer error handling. - Moved `SyncVaultDataResult` to `com.x8bit.bitwarden.data.vault.manager.model`. - Updated DI modules and tests to reflect these changes. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:19:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?