github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2000] [MERGED] [PS-1080] Added text alternative to Boolean custom field icon #60552

New Issue
Closed
opened 2026-05-11 23:42:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 23:42:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2000
Author: @aj-rosado
Created: 7/20/2022
Status: ✅ Merged
Merged: 7/21/2022
Merged by: @aj-rosado

Base: master ← Head: bug/PS-1080-Accessibility-text-on-bool-custom-field

📝 Commits (2)

  • 1253f68 PS-1080 Added new accessibility text property to the custom field bool icon
  • 9008341 PS-1080 Added BoolValue property to the FieldView and added new AccessibilityProperty to bool icon

📊 Changes

3 files changed (+18 additions, -1 deletions)

View changed files

📝 src/App/Pages/Vault/ViewPage.xaml (+2 -0)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+15 -1)
📝 src/Core/Models/View/FieldView.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Screen Reader should be able to read if the Boolean icon value on custom fields is Enabled or Disabled

Code changes

  • ViewPage.xaml: Added AutomationProperties.Name accessibility property to the CustomField boolean IconLabel.
  • ViewPageViewModel: Added a new property named ValueAccessibilityText that has the value to use on the xaml accessibility property.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2000 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 7/20/2022 **Status:** ✅ Merged **Merged:** 7/21/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bug/PS-1080-Accessibility-text-on-bool-custom-field` --- ### 📝 Commits (2) - [`1253f68`](https://github.com/bitwarden/android/commit/1253f68e7323279f0d6e0a53cd4d32aca8337ac0) PS-1080 Added new accessibility text property to the custom field bool icon - [`9008341`](https://github.com/bitwarden/android/commit/900834145ecc956f65139fd305fb4b2833c0eb3d) PS-1080 Added BoolValue property to the FieldView and added new AccessibilityProperty to bool icon ### 📊 Changes **3 files changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/ViewPage.xaml` (+2 -0) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+15 -1) 📝 `src/Core/Models/View/FieldView.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Screen Reader should be able to read if the Boolean icon value on custom fields is Enabled or Disabled ## Code changes * **ViewPage.xaml**: Added `AutomationProperties.Name` accessibility property to the CustomField boolean IconLabel. * **ViewPageViewModel**: Added a new property named `ValueAccessibilityText` that has the value to use on the xaml accessibility property. ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 23:42:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#60552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?