[PR #5689] [PM-24411] Generalize IntentManager activity handling #5969

New Issue

2025-11-27T00:17:52-06:00

GiteaMirror commented

2025-11-27 00:17:52 -06:00

Original Pull Request: https://github.com/bitwarden/android/pull/5689

State: closed
Merged: Yes

🎟️ Tracking

PM-24411

📔 Objective

Moved several methods from IntentManager and IntentManagerImpl to a new IntentManagerUtils.kt file as extension functions.
This change improves code organization and prepares for future modularization.

The following methods were moved:

startSystemAutofillSettingsActivity
startSystemAccessibilitySettingsActivity
startBrowserAutofillSettingsActivity
startApplicationDetailsSettingsActivity
startDefaultEmailApplication

The startActivity method in IntentManager now returns a Boolean indicating success or failure.
Updated call sites to reflect these changes, including passing Context where now required.
Unit tests were also updated to mock static utils methods.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

**Original Pull Request:** https://github.com/bitwarden/android/pull/5689 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-24411 ## 📔 Objective Moved several methods from `IntentManager` and `IntentManagerImpl` to a new `IntentManagerUtils.kt` file as extension functions. This change improves code organization and prepares for future modularization. The following methods were moved: - `startSystemAutofillSettingsActivity` - `startSystemAccessibilitySettingsActivity` - `startBrowserAutofillSettingsActivity` - `startApplicationDetailsSettingsActivity` - `startDefaultEmailApplication` The `startActivity` method in `IntentManager` now returns a `Boolean` indicating success or failure. Updated call sites to reflect these changes, including passing `Context` where now required. Unit tests were also updated to mock static utils methods. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes

GiteaMirror added the pull-request label 2025-11-27 00:17:52 -06:00

GiteaMirror closed this issue