github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-21 00:33:17 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6881] [MERGED] [PM-32810] test: Cover Bank Account vault, listing, and search surfaces #59647

New Issue
Closed
opened 2026-05-11 06:38:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 06:38:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6881
Author: @SaintPatrck
Created: 5/7/2026
Status: ✅ Merged
Merged: 5/7/2026
Merged by: @SaintPatrck

Base: main ← Head: new-item-types/PM-32810_bank-account-coverage

📝 Commits (1)

  • bf6dc81 PM-32810 test: Cover Bank Account vault, listing, and search surfaces

📊 Changes

5 files changed (+115 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchNavigation.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingNavigation.kt (+3 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensionsTest.kt (+35 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt (+62 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingStateExtensionsTest.kt (+12 -0)

📄 Description

🎟️ Tracking

PM-32810

Follow-up to #6877.

📔 Objective

Closes the Bank Account coverage gaps surfaced by Codecov on #6877. Adds test coverage for the new BankAccount branches in the Search and Item Listing utility extensions, and excludes the affected navigation files from coverage at both file and class level — matching the convention used by other navigation files in the project.

  • SearchTypeDataExtensions: covers BankAccounts arms in updateWithAdditionalDataIfNecessary and filterAndOrganize.
  • VaultItemListingStateExtensions: covers BankAccount arms in toSearchType() and toVaultItemCipherType().
  • VaultItemListingDataExtensions: covers the BankAccount listing predicate, no-items state (message, button, header), and updateWithAdditionalDataIfNecessary.
  • SearchNavigation and VaultItemListingNavigation annotated with @file:OmitFromCoverage.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6881 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/7/2026 **Status:** ✅ Merged **Merged:** 5/7/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `new-item-types/PM-32810_bank-account-coverage` --- ### 📝 Commits (1) - [`bf6dc81`](https://github.com/bitwarden/android/commit/bf6dc81fb6cca7abfac0a65ba5fd608045bff25d) [PM-32810] test: Cover Bank Account vault, listing, and search surfaces ### 📊 Changes **5 files changed** (+115 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchNavigation.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingNavigation.kt` (+3 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensionsTest.kt` (+35 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt` (+62 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingStateExtensionsTest.kt` (+12 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-32810](https://bitwarden.atlassian.net/browse/PM-32810) Follow-up to #6877. ## 📔 Objective Closes the Bank Account coverage gaps surfaced by Codecov on #6877. Adds test coverage for the new `BankAccount` branches in the Search and Item Listing utility extensions, and excludes the affected navigation files from coverage at both file and class level — matching the convention used by other navigation files in the project. - `SearchTypeDataExtensions`: covers `BankAccounts` arms in `updateWithAdditionalDataIfNecessary` and `filterAndOrganize`. - `VaultItemListingStateExtensions`: covers `BankAccount` arms in `toSearchType()` and `toVaultItemCipherType()`. - `VaultItemListingDataExtensions`: covers the `BankAccount` listing predicate, no-items state (message, button, header), and `updateWithAdditionalDataIfNecessary`. - `SearchNavigation` and `VaultItemListingNavigation` annotated with `@file:OmitFromCoverage`. [PM-32810]: https://bitwarden.atlassian.net/browse/PM-32810?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 06:38:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#59647