github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5677] [MERGED] [PM-24642] Remove captcha connector code #5961

New Issue
Closed
opened 2025-11-27 00:17:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:17:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5677
Author: @aj-rosado
Created: 8/11/2025
Status: ✅ Merged
Merged: 8/12/2025
Merged by: @aj-rosado

Base: main ← Head: PM-24642/remove-captcha-connector-code

📝 Commits (5)

  • 5e0871e Removed captcha connector code
  • e366912 Merge branch 'main' into PM-7064/remove-captcha-connector-code
  • 89dadd2 removed remaining captcha references
  • d346184 removed intent filter from manifest and removed unused intentManager from LoginScreen
  • b0c411b removed whitespace on LoginScreen

📊 Changes

44 files changed (+71 additions, -1569 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+0 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackViewModel.kt (+0 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+0 -18)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+1 -38)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResult.kt (+0 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/RegisterResult.kt (+1 -9)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/CaptchaUtils.kt (+0 -74)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+1 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+1 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+1 -16)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt (+0 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt (+0 -62)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginNavigation.kt (+2 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginScreen.kt (+0 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt (+0 -63)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt (+0 -6)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModel.kt (+0 -60)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt (+0 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+0 -60)

...and 24 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24642

📔 Objective

Captcha connector has been removed from server and other clients, it is not used anymore so this is a cleanup of that

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5677 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 8/11/2025 **Status:** ✅ Merged **Merged:** 8/12/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-24642/remove-captcha-connector-code` --- ### 📝 Commits (5) - [`5e0871e`](https://github.com/bitwarden/android/commit/5e0871e88adae9c7c9c4748b17151514f3d08995) Removed captcha connector code - [`e366912`](https://github.com/bitwarden/android/commit/e36691279fc7745f5d761ecdee2ab4ce257b7f8a) Merge branch 'main' into PM-7064/remove-captcha-connector-code - [`89dadd2`](https://github.com/bitwarden/android/commit/89dadd277451d90c24e06d2a107143a633223c29) removed remaining captcha references - [`d346184`](https://github.com/bitwarden/android/commit/d346184bb412ce82983ccedff62f00a4ae40771b) removed intent filter from manifest and removed unused intentManager from LoginScreen - [`b0c411b`](https://github.com/bitwarden/android/commit/b0c411b5382ba03edd48f29c559d884ddc1b18c9) removed whitespace on LoginScreen ### 📊 Changes **44 files changed** (+71 additions, -1569 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+0 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackViewModel.kt` (+0 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+0 -18) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+1 -38) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/LoginResult.kt` (+0 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/RegisterResult.kt` (+1 -9) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/CaptchaUtils.kt` (+0 -74) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+1 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+1 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+1 -16) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt` (+0 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt` (+0 -62) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginNavigation.kt` (+2 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginScreen.kt` (+0 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt` (+0 -63) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceScreen.kt` (+0 -6) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/loginwithdevice/LoginWithDeviceViewModel.kt` (+0 -60) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt` (+0 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+0 -60) _...and 24 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-24642 ## 📔 Objective Captcha connector has been removed from server and other clients, it is not used anymore so this is a cleanup of that ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:17:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?