github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5670] [CLOSED] [BRE-1074] Fixing publish locales #5957

New Issue
Closed
opened 2025-11-27 00:17:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:17:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5670
Author: @pixman20
Created: 8/8/2025
Status: ❌ Closed

Base: main ← Head: BRE-1074-fix-mobile-publishing

📝 Commits (10+)

  • 44fdbec debugging localization bug
  • df2c703 debugging localization bug
  • aa9e151 debugging localization bug
  • a0874a7 pass package name to format release notes
  • f77839e adding error for invalid package name
  • a79634e remove debugging text
  • 302602a remove misleading ui message
  • 23b7459 Adding debug info
  • 2048050 Merge remote-tracking branch 'origin/main' into agalles/20250807release
  • 722e273 Merge remote-tracking branch 'origin/main' into agalles/20250807release

📊 Changes

3 files changed (+10 additions, -2 deletions)

View changed files

📝 .github/workflows/publish-store.yml (+2 -1)
📝 fastlane/Fastfile (+4 -0)
📝 fastlane/patches/supply_custom_promote.rb (+4 -1)

📄 Description

🎟️ Tracking

BRE-1074

📔 Objective

Fixing publish locales using the correct project name. Also adding debug information for failing to find release

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5670 **Author:** [@pixman20](https://github.com/pixman20) **Created:** 8/8/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `BRE-1074-fix-mobile-publishing` --- ### 📝 Commits (10+) - [`44fdbec`](https://github.com/bitwarden/android/commit/44fdbec92c02117bab98ed26d040e84a87990b22) debugging localization bug - [`df2c703`](https://github.com/bitwarden/android/commit/df2c7039b209e01a7d359fbe904b5946f36fb4c4) debugging localization bug - [`aa9e151`](https://github.com/bitwarden/android/commit/aa9e151a0ba6bca733d9ed2b6f6475eaba65831f) debugging localization bug - [`a0874a7`](https://github.com/bitwarden/android/commit/a0874a7c4f1898f85528a58ade9bc39e8ce0499c) pass package name to format release notes - [`f77839e`](https://github.com/bitwarden/android/commit/f77839e7580ccd8beaa83f0c45849556972172c9) adding error for invalid package name - [`a79634e`](https://github.com/bitwarden/android/commit/a79634e34b77bfb3993bb62b11b5899fc5fd97b0) remove debugging text - [`302602a`](https://github.com/bitwarden/android/commit/302602a9337617fa606c0f63c445d1384bf896ae) remove misleading ui message - [`23b7459`](https://github.com/bitwarden/android/commit/23b745991a59b4125d576e9771646197e5aaec18) Adding debug info - [`2048050`](https://github.com/bitwarden/android/commit/204805047846ec1606ffec93f5031afe1d04f233) Merge remote-tracking branch 'origin/main' into agalles/20250807release - [`722e273`](https://github.com/bitwarden/android/commit/722e2732f07f65fd8964219636e10974e5afed5f) Merge remote-tracking branch 'origin/main' into agalles/20250807release ### 📊 Changes **3 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish-store.yml` (+2 -1) 📝 `fastlane/Fastfile` (+4 -0) 📝 `fastlane/patches/supply_custom_promote.rb` (+4 -1) </details> ### 📄 Description ## 🎟️ Tracking [BRE-1074](https://bitwarden.atlassian.net/browse/BRE-1074) ## 📔 Objective Fixing publish locales using the correct project name. Also adding debug information for failing to find release ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [BRE-1074]: https://bitwarden.atlassian.net/browse/BRE-1074?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:17:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5957
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?