github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-17 03:59:18 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6713] [MERGED] chore: Update RootNavScreen to enforce state-based navigation #59562

New Issue
Closed
opened 2026-05-11 05:54:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 05:54:59 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6713
Author: @david-livefront
Created: 3/24/2026
Status: ✅ Merged
Merged: 3/25/2026
Merged by: @david-livefront

Base: main ← Head: clean-up-root-nav

📝 Commits (1)

  • e412211 Update RootNavScreen to enforce state-based navigation

📊 Changes

5 files changed (+83 additions, -29 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+5 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/preventaccountlockout/PreventAccountLockoutNavigation.kt (+34 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/resetpassword/ResetPasswordNavigation.kt (+32 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt (+10 -15)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt (+2 -2)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR cleans up a small bit of code where we were mixing event-based navigation into the RootNavScreen where only state-based navigation should be allowed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6713 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/24/2026 **Status:** ✅ Merged **Merged:** 3/25/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `clean-up-root-nav` --- ### 📝 Commits (1) - [`e412211`](https://github.com/bitwarden/android/commit/e412211dc6d757b36cda0136e82925db6b3a2a5d) Update RootNavScreen to enforce state-based navigation ### 📊 Changes **5 files changed** (+83 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+5 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/preventaccountlockout/PreventAccountLockoutNavigation.kt` (+34 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/resetpassword/ResetPasswordNavigation.kt` (+32 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt` (+10 -15) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreenTest.kt` (+2 -2) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR cleans up a small bit of code where we were mixing event-based navigation into the `RootNavScreen` where only state-based navigation should be allowed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 05:54:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#59562