github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5666] [MERGED] [PM-24564] Address GitHub Release creation workflow feedback #5953

New Issue
Closed
opened 2025-11-27 00:17:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:17:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5666
Author: @vvolkgang
Created: 8/8/2025
Status: ✅ Merged
Merged: 8/8/2025
Merged by: @vvolkgang

Base: main ← Head: monorepo/fix-gh-release

📝 Commits (9)

  • 8f5832c Add log inputs action
  • 18ac372 Add logs to branch from run step
  • f47e6e0 Set gh release --latest to false for Authenticator releases
  • 14d31a3 fix: gh releases diff using wrong branch
  • 0e1c40e Use release ID instead of tag name to update releases to fix wrong releases being updated when the workflow is triggered multiple times
  • bccdb93 Remove non production artifacts from release
  • 1bffa40 Change step order
  • aa76406 Adding logs to internal artifacts removal
  • bc053d2 Fix logs

📊 Changes

2 files changed (+80 additions, -16 deletions)

View changed files

➕ .github/actions/log-inputs/action.yml (+20 -0)
📝 .github/workflows/github-release.yml (+60 -16)

📄 Description

🎟️ Tracking

PM-24564

📔 Objective

QoL improvements and fixes to the GitHub Release Creation workflow:

  • Remove internal artifacts from the GitHub Release
  • Set "Publish as Latest" as false for Authenticator
  • fix: gh release diff link using the wrong app tag (bwa diffing with bwpm)
  • fix: consecutive workflow runs would update older drafts, by using the release ID instead of the release tag for updates

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5666 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 8/8/2025 **Status:** ✅ Merged **Merged:** 8/8/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `monorepo/fix-gh-release` --- ### 📝 Commits (9) - [`8f5832c`](https://github.com/bitwarden/android/commit/8f5832c87181603319ac36d7852fc6ed862a388c) Add log inputs action - [`18ac372`](https://github.com/bitwarden/android/commit/18ac372524be3b740e5146298be5545c514e2bdf) Add logs to branch from run step - [`f47e6e0`](https://github.com/bitwarden/android/commit/f47e6e07c70a2bbee61c2d81144682f207369661) Set gh release --latest to false for Authenticator releases - [`14d31a3`](https://github.com/bitwarden/android/commit/14d31a32115e3b32302d859fdf3499cd8e38118d) fix: gh releases diff using wrong branch - [`0e1c40e`](https://github.com/bitwarden/android/commit/0e1c40e84f2af10f5ae896a1f75a6d20a509efa8) Use release ID instead of tag name to update releases to fix wrong releases being updated when the workflow is triggered multiple times - [`bccdb93`](https://github.com/bitwarden/android/commit/bccdb932f1fa29bcd9a0bc6d4318a19504aa3dc6) Remove non production artifacts from release - [`1bffa40`](https://github.com/bitwarden/android/commit/1bffa4004c260779ec58305a6d07d12639968c3b) Change step order - [`aa76406`](https://github.com/bitwarden/android/commit/aa764067555c966e956911860626872a34e4dc03) Adding logs to internal artifacts removal - [`bc053d2`](https://github.com/bitwarden/android/commit/bc053d2fecd41f2f5cfdaabe0a89ad494c1827c0) Fix logs ### 📊 Changes **2 files changed** (+80 additions, -16 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/log-inputs/action.yml` (+20 -0) 📝 `.github/workflows/github-release.yml` (+60 -16) </details> ### 📄 Description ## 🎟️ Tracking PM-24564 ## 📔 Objective QoL improvements and fixes to the GitHub Release Creation workflow: * Remove internal artifacts from the GitHub Release * Set "Publish as Latest" as false for Authenticator * fix: gh release diff link using the wrong app tag (bwa diffing with bwpm) * fix: consecutive workflow runs would update older drafts, by using the release ID instead of the release tag for updates ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:17:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?