github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-18 10:17:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6664] [MERGED] [PM-33356] feat: Sync when push notification policy changed is received #59517

New Issue
Closed
opened 2026-05-11 05:42:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 05:42:06 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6664
Author: @andrebispo5
Created: 3/13/2026
Status: ✅ Merged
Merged: 3/16/2026
Merged by: @andrebispo5

Base: main ← Head: pm-33356/policy-changed-push-sync

📝 Commits (5)

📊 Changes

3 files changed (+38 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/NotificationType.kt (+3 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerTest.kt (+29 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33356

📔 Objective

This pull request adds support for handling a new type of push notification indicating that an organization policy has changed. The implementation ensures that when a "policy changed" notification is received, a full sync is triggered for the active user. Corresponding tests have been added to verify this behavior.

Push notification handling:

  • Added a new notification type, POLICY_CHANGED, to the NotificationType enum to represent policy change events.
  • Updated PushManagerImpl to emit the active user ID to the fullSyncSharedFlow when a POLICY_CHANGED notification is received, triggering a full sync.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6664 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/16/2026 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-33356/policy-changed-push-sync` --- ### 📝 Commits (5) - [`11a0f05`](https://github.com/bitwarden/android/commit/11a0f05f9520013b67961ddf049d2d211a31c670) [PM-33356] Sync on policy changed notification - [`4974e21`](https://github.com/bitwarden/android/commit/4974e21f7b25fa88901128836a51dc2ccb769842) Merge branch 'main' into pm-33356/policy-changed-push-sync - [`4ab25b4`](https://github.com/bitwarden/android/commit/4ab25b46432a7d43b008959df1dcb007cf1a60eb) [PM-33356] Fix test change - [`1db1f14`](https://github.com/bitwarden/android/commit/1db1f14930ece27bab0f6dc7b71c62ddade41196) Merge branch 'pm-33356/policy-changed-push-sync' of https://github.com/bitwarden/android into pm-33356/policy-changed-push-sync - [`f5e6dca`](https://github.com/bitwarden/android/commit/f5e6dcae040012fcef6d00985f336226dc98f182) [PM-33356] Update test name ### 📊 Changes **3 files changed** (+38 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerImpl.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/NotificationType.kt` (+3 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/PushManagerTest.kt` (+29 -0) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-33356 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> This pull request adds support for handling a new type of push notification indicating that an organization policy has changed. The implementation ensures that when a "policy changed" notification is received, a full sync is triggered for the active user. Corresponding tests have been added to verify this behavior. **Push notification handling:** * Added a new notification type, `POLICY_CHANGED`, to the `NotificationType` enum to represent policy change events. * Updated `PushManagerImpl` to emit the active user ID to the `fullSyncSharedFlow` when a `POLICY_CHANGED` notification is received, triggering a full sync. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 05:42:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#59517