github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6657] [MERGED] [PM-33507] feat: Add premium upgrade banner dismissal persistence #59511

New Issue
Closed
opened 2026-05-11 05:40:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 05:40:33 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6657
Author: @SaintPatrck
Created: 3/12/2026
Status: ✅ Merged
Merged: 3/13/2026
Merged by: @SaintPatrck

Base: main ← Head: premium-upgrade/PM-33507-banner-dismissal-persistence

📝 Commits (1)

📊 Changes

7 files changed (+191 additions, -0 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt (+18 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt (+33 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+10 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+23 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt (+45 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt (+30 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+32 -0)

📄 Description

🎟️ Tracking

PM-33507
Parent: PM-33137

📔 Objective

Add per-user banner dismissed state to SettingsDiskSource and SettingsRepository, following the existing archive action card pattern.

  • Add get/storePremiumUpgradeBannerDismissed + flow to SettingsDiskSource
  • Implement in SettingsDiskSourceImpl with per-userId SharedPreferences storage
  • Expose dismissPremiumUpgradeBanner() and getPremiumUpgradeBannerDismissedFlow() via SettingsRepository
  • Dismissed state cleared on logout

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6657 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/12/2026 **Status:** ✅ Merged **Merged:** 3/13/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `premium-upgrade/PM-33507-banner-dismissal-persistence` --- ### 📝 Commits (1) - [`dccd7e7`](https://github.com/bitwarden/android/commit/dccd7e781621c85fbb987fe3bc360adb66e9da28) [PM-33137] feat: Add premium upgrade banner dismissal persistence ### 📊 Changes **7 files changed** (+191 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSource.kt` (+18 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt` (+33 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+10 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+23 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceTest.kt` (+45 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/datasource/disk/util/FakeSettingsDiskSource.kt` (+30 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+32 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-33507](https://bitwarden.atlassian.net/browse/PM-33507) Parent: [PM-33137](https://bitwarden.atlassian.net/browse/PM-33137) ## 📔 Objective Add per-user banner dismissed state to `SettingsDiskSource` and `SettingsRepository`, following the existing archive action card pattern. - Add `get/storePremiumUpgradeBannerDismissed` + flow to `SettingsDiskSource` - Implement in `SettingsDiskSourceImpl` with per-userId SharedPreferences storage - Expose `dismissPremiumUpgradeBanner()` and `getPremiumUpgradeBannerDismissedFlow()` via `SettingsRepository` - Dismissed state cleared on logout [PM-33507]: https://bitwarden.atlassian.net/browse/PM-33507?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-33137]: https://bitwarden.atlassian.net/browse/PM-33137?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 05:40:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#59511