github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-13 22:08:44 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6527] [MERGED] PM-32146: Add back 'parent' param to webAuthn url #59397

New Issue
Closed
opened 2026-05-11 05:10:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-11 05:10:25 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6527
Author: @david-livefront
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @david-livefront

Base: main ← Head: PM-32146-web-authn-fix

📝 Commits (1)

  • e1ceb1b PM-32146: Add back 'parent' param to webAuthn url

📊 Changes

4 files changed (+15 additions, -6 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WebAuthUtils.kt (+6 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WebAuthUtilsTest.kt (+6 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt (+2 -2)

📄 Description

🎟️ Tracking

PM-32146

📔 Objective

This PR adds back the parent param to the WebAuthn url launched into a browser. This parameter will not be needed in the future but we still need it today!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6527 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-32146-web-authn-fix` --- ### 📝 Commits (1) - [`e1ceb1b`](https://github.com/bitwarden/android/commit/e1ceb1b7f3087f08e08a3a2ca96a5eabb2b5e770) PM-32146: Add back 'parent' param to webAuthn url ### 📊 Changes **4 files changed** (+15 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WebAuthUtils.kt` (+6 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/WebAuthUtilsTest.kt` (+6 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt` (+2 -2) </details> ### 📄 Description ## 🎟️ Tracking [PM-32146](https://bitwarden.atlassian.net/browse/PM-32146) ## 📔 Objective This PR adds back the `parent` param to the WebAuthn url launched into a browser. This parameter will not be needed in the future but we still need it today! [PM-32146]: https://bitwarden.atlassian.net/browse/PM-32146?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-11 05:10:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#59397