github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5649] [MERGED] Fix autofill overwriting user data with empty field values #5939

New Issue
Closed
opened 2025-11-27 00:17:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:17:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5649
Author: @tomikonio
Created: 8/5/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @SaintPatrck

Base: main ← Head: fix-autofill-of-empty-values

📝 Commits (6)

  • d78b63d Fix autofill overwriting user data with empty field values
  • b1c0acc Add the empty value check to the buildFilledItemOrNull method
  • f13b708 Merge branch 'main' into fix-autofill-of-empty-values
  • 3f63d11 Format code
  • 635cb7d Add test for empty value
  • c7d2c09 Merge branch 'main' into fix-autofill-of-empty-values

📊 Changes

2 files changed (+45 additions, -20 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillViewExtensions.kt (+25 -20)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillViewExtensionsTest.kt (+20 -0)

📄 Description

🎟️ Tracking

Fixes #5648

📔 Objective

Fix Android autofill service overwriting user-entered form data with empty values when vault items contain empty fields.
This affects both login credentials (username/password) and payment card information, preventing data loss and improving user experience.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5649 **Author:** [@tomikonio](https://github.com/tomikonio) **Created:** 8/5/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `fix-autofill-of-empty-values` --- ### 📝 Commits (6) - [`d78b63d`](https://github.com/bitwarden/android/commit/d78b63dd4627ecf03c8f77e32d41eb693962cb93) Fix autofill overwriting user data with empty field values - [`b1c0acc`](https://github.com/bitwarden/android/commit/b1c0accff616a0fcdf1a3a51f9f3fd90cf40930b) Add the empty value check to the buildFilledItemOrNull method - [`f13b708`](https://github.com/bitwarden/android/commit/f13b708d84ac61360bd3c480d7d7761012a76b51) Merge branch 'main' into fix-autofill-of-empty-values - [`3f63d11`](https://github.com/bitwarden/android/commit/3f63d1197f8c5cf0c4ab4d908adc29a0b493829b) Format code - [`635cb7d`](https://github.com/bitwarden/android/commit/635cb7d2ccb27136b5706d5d4c359a4a0003c7f9) Add test for empty value - [`c7d2c09`](https://github.com/bitwarden/android/commit/c7d2c09125f0b7c00821562873fcede22fb039bb) Merge branch 'main' into fix-autofill-of-empty-values ### 📊 Changes **2 files changed** (+45 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillViewExtensions.kt` (+25 -20) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillViewExtensionsTest.kt` (+20 -0) </details> ### 📄 Description ## 🎟️ Tracking Fixes #5648 ## 📔 Objective Fix Android autofill service overwriting user-entered form data with empty values when vault items contain empty fields. This affects both login credentials (username/password) and payment card information, preventing data loss and improving user experience. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:17:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?