github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #5634] [MERGED] [PM-24411] Migrate IntentManager to ui module #5927

New Issue
Closed
opened 2025-11-27 00:17:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:17:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5634
Author: @SaintPatrck
Created: 8/1/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @SaintPatrck

Base: main ← Head: poc-ui-error-report-sharing-part-deux

📝 Commits (10+)

  • ab745f7 [PM-24411] Extract Authenticator functions from IntentManager
  • 6b5abef Refactor IntentManager and introduce BuildInfoManager
  • 36de1fd Update references so project cam build. Review the previous commit to remove noise.
  • fb70fef Move browser related models back to app module
  • 5b675bb Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux
  • 83275b7 Revert change to ItemListingViewModelTest
  • 462284f Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux
  • c335e7c Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux
  • 87bea8b Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux
  • 933ed35 Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux

📊 Changes

90 files changed (+170 additions, -325 deletions)

View changed files

📝 .github/workflows/build-authenticator.yml (+9 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthRequestNotificationManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/FilledDataExtensions.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/IntExtensions.kt (+0 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/CredentialManagerPendingIntentManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/environment/EnvironmentScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenBasicDialog.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt (+3 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+1 -1)
���� app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt (+2 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt (+2 -2)

...and 70 more files

📄 Description

🎟️ Tracking

PM-24411

📔 Objective

This commit refactors the IntentManager to be more generic and reusable by moving it to the ui module.

Key changes:

  • Moved IntentManager and its implementation to the ui module.
  • IntentManager now accepts a BuildInfoManager instance to access build-specific data like applicationId, versionData, etc.
  • LocalIntentManager is now provided from the ui module.
  • Updated dependency injection for IntentManager in PlatformUiManagerModule to include BuildInfoManager.
  • Added toPendingIntentMutabilityFlag() extension function to Int in the core module.
  • Updated build.gradle.kts files to reflect new dependencies and build configurations, including adding CI_INFO and SDK_VERSION to the authenticator build config.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5634 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 8/1/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `poc-ui-error-report-sharing-part-deux` --- ### 📝 Commits (10+) - [`ab745f7`](https://github.com/bitwarden/android/commit/ab745f78592247f1bca69a6c9e618f03e261004c) [PM-24411] Extract Authenticator functions from IntentManager - [`6b5abef`](https://github.com/bitwarden/android/commit/6b5abef076cd4944dbc864ff80c65f2cc64f8e28) Refactor IntentManager and introduce BuildInfoManager - [`36de1fd`](https://github.com/bitwarden/android/commit/36de1fde8b6aa34a3cc8a34579d7844a8b0a783a) Update references so project cam build. Review the previous commit to remove noise. - [`fb70fef`](https://github.com/bitwarden/android/commit/fb70fef8cd046feeec03fd7f0bad29cab73610b4) Move browser related models back to app module - [`5b675bb`](https://github.com/bitwarden/android/commit/5b675bbcf40d8e624bb7041ee9b72aac49dda36d) Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux - [`83275b7`](https://github.com/bitwarden/android/commit/83275b7cf4e0c26233648c89ceba4ab955540896) Revert change to ItemListingViewModelTest - [`462284f`](https://github.com/bitwarden/android/commit/462284fe70f887c561683ddee31b3c7a9d5cf1ff) Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux - [`c335e7c`](https://github.com/bitwarden/android/commit/c335e7cad8728e10434f4c206466939eee95047f) Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux - [`87bea8b`](https://github.com/bitwarden/android/commit/87bea8b496bb4c19d70edf249217bffa46c4aa7f) Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux - [`933ed35`](https://github.com/bitwarden/android/commit/933ed350a8118781426d35abf153005c705919a0) Merge remote-tracking branch 'origin/main' into poc-ui-error-report-sharing-part-deux ### 📊 Changes **90 files changed** (+170 additions, -325 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-authenticator.yml` (+9 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/MainViewModel.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/AuthRequestNotificationManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/FilledDataExtensions.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/IntExtensions.kt` (+0 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/CredentialManagerPendingIntentManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/environment/EnvironmentScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenBasicDialog.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/composition/LocalManagerProvider.kt` (+3 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+1 -1) ���� `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt` (+2 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt` (+2 -2) _...and 70 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-24411 ## 📔 Objective This commit refactors the `IntentManager` to be more generic and reusable by moving it to the `ui` module. Key changes: - Moved `IntentManager` and its implementation to the `ui` module. - `IntentManager` now accepts a `BuildInfoManager` instance to access build-specific data like `applicationId`, `versionData`, etc. - `LocalIntentManager` is now provided from the `ui` module. - Updated dependency injection for `IntentManager` in `PlatformUiManagerModule` to include `BuildInfoManager`. - Added `toPendingIntentMutabilityFlag()` extension function to `Int` in the `core` module. - Updated `build.gradle.kts` files to reflect new dependencies and build configurations, including adding `CI_INFO` and `SDK_VERSION` to the authenticator build config. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:17:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5927
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?