github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5616] [CLOSED] [PoC] Refactor error reporting to use BitwardenBuildConfigManager #5913

New Issue
Closed
opened 2025-11-27 00:16:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:16:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5616
Author: @SaintPatrck
Created: 7/29/2025
Status: ❌ Closed

Base: main ← Head: poc-ui-error-report-sharing-abstraction

📝 Commits (2)

  • fef0db0 Refactor error reporting to use BitwardenBuildConfigManager
  • 261bf08 Refactor IntentManager into smaller, focused interfaces

📊 Changes

24 files changed (+1177 additions, -659 deletions)

View changed files

➕ app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/BitwardenBuildConfigManagerImpl.kt (+40 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenBasicDialog.kt (+1 -15)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ActivityResultIntentManager.kt (+20 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ActivityResultIntentManagerImpl.kt (+26 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ApplicationDataIntentManager.kt (+11 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ApplicationDataIntentManagerImpl.kt (+31 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/AutofillIntentManager.kt (+30 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/AutofillIntentManagerImpl.kt (+61 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/CredentialManagerIntentManager.kt (+81 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/CredentialManagerIntentManagerImpl.kt (+168 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ExternalLinkIntentManager.kt (+18 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ExternalLinkIntentManagerImpl.kt (+74 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/FileIntentManager.kt (+21 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/FileIntentManagerImpl.kt (+99 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt (+9 -193)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt (+18 -451)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ShareIntentManager.kt (+54 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ShareIntentManagerImpl.kt (+204 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/TileIntentManager.kt (+20 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/TileIntentManagerImpl.kt (+39 -0)

...and 4 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

Rough proposal to abstract error report generation from BitwardenDialog components.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5616 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `poc-ui-error-report-sharing-abstraction` --- ### 📝 Commits (2) - [`fef0db0`](https://github.com/bitwarden/android/commit/fef0db0c9655a3da781c34c3b10b08cf99432e08) Refactor error reporting to use BitwardenBuildConfigManager - [`261bf08`](https://github.com/bitwarden/android/commit/261bf08edfc22fbf1878e4b3700cb92ccdeb12b0) Refactor IntentManager into smaller, focused interfaces ### 📊 Changes **24 files changed** (+1177 additions, -659 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/BitwardenBuildConfigManagerImpl.kt` (+40 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenBasicDialog.kt` (+1 -15) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ActivityResultIntentManager.kt` (+20 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ActivityResultIntentManagerImpl.kt` (+26 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ApplicationDataIntentManager.kt` (+11 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ApplicationDataIntentManagerImpl.kt` (+31 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/AutofillIntentManager.kt` (+30 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/AutofillIntentManagerImpl.kt` (+61 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/CredentialManagerIntentManager.kt` (+81 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/CredentialManagerIntentManagerImpl.kt` (+168 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ExternalLinkIntentManager.kt` (+18 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ExternalLinkIntentManagerImpl.kt` (+74 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/FileIntentManager.kt` (+21 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/FileIntentManagerImpl.kt` (+99 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt` (+9 -193) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt` (+18 -451) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ShareIntentManager.kt` (+54 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/ShareIntentManagerImpl.kt` (+204 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/TileIntentManager.kt` (+20 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/manager/intent/TileIntentManagerImpl.kt` (+39 -0) _...and 4 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective Rough proposal to abstract error report generation from BitwardenDialog components. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:16:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5913
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?