github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5587] [MERGED] [PM-24175] Refactor Crowdin workflow #5892

New Issue
Closed
opened 2025-11-27 00:16:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:16:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5587
Author: @SaintPatrck
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/30/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-24113/delete-authenticator-string-resources

📝 Commits (1)

  • a9eba0e Refactor Crowdin workflow and remove Authenticator strings

📊 Changes

4 files changed (+10 additions, -46 deletions)

View changed files

📝 .github/workflows/crowdin-pull.yml (+8 -19)
📝 .github/workflows/crowdin-push.yml (+2 -13)
➖ crowdin-bwa.yml (+0 -9)
📝 crowdin.yml (+0 -5)

📄 Description

🎟️ Tracking

PM-24175

📔 Objective

This commit refactors the Crowdin GitHub Actions workflows to consolidate them and removes the crowdin-bwa.yml configuration file.

Key changes:

  • Deleted crowdin-bwa.yml.
  • Updated .github/workflows/crowdin-push.yml to use a single "Upload sources" step with crowdin.yml.
  • Updated .github/workflows/crowdin-pull.yml:
    • Removed the matrix strategy for different projects.
    • Simplified job name and commit/pull request messages.
    • Hardcoded project_id to "269690" (formerly Password Manager's ID).
    • Hardcoded config to crowdin.yml.
    • Hardcoded localization_branch_name to "crowdin-pull-bwpm".
  • Removed the /app/src/main/res/values/strings.xml source from the (now renamed) crowdin.yml as it is no longer needed.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5587 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/30/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-24113/delete-authenticator-string-resources` --- ### 📝 Commits (1) - [`a9eba0e`](https://github.com/bitwarden/android/commit/a9eba0e950f3954a44d94fe9f1e8a1f015fe8b15) Refactor Crowdin workflow and remove Authenticator strings ### 📊 Changes **4 files changed** (+10 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/crowdin-pull.yml` (+8 -19) 📝 `.github/workflows/crowdin-push.yml` (+2 -13) ➖ `crowdin-bwa.yml` (+0 -9) 📝 `crowdin.yml` (+0 -5) </details> ### 📄 Description ## 🎟️ Tracking PM-24175 ## 📔 Objective This commit refactors the Crowdin GitHub Actions workflows to consolidate them and removes the `crowdin-bwa.yml` configuration file. Key changes: - Deleted `crowdin-bwa.yml`. - Updated `.github/workflows/crowdin-push.yml` to use a single "Upload sources" step with `crowdin.yml`. - Updated `.github/workflows/crowdin-pull.yml`: - Removed the matrix strategy for different projects. - Simplified job name and commit/pull request messages. - Hardcoded `project_id` to "269690" (formerly Password Manager's ID). - Hardcoded `config` to `crowdin.yml`. - Hardcoded `localization_branch_name` to "crowdin-pull-bwpm". - Removed the `/app/src/main/res/values/strings.xml` source from the (now renamed) `crowdin.yml` as it is no longer needed. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:16:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?