github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5575] [MERGED] PM-24137, PM-24138: Remove host alias feature flags #5880

New Issue
Closed
opened 2025-11-27 00:16:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:16:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5575
Author: @david-livefront
Created: 7/24/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @david-livefront

Base: main ← Head: PM-24137-PM-24138-remove-host-alias-flags

📝 Commits (1)

  • baaa523 PM-24137, PM-24138: Remove host alias feature flags

📊 Changes

11 files changed (+44 additions, -416 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+0 -19)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+0 -6)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+23 -38)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+1 -76)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/util/ServiceTypeExtensions.kt (+2 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+0 -6)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+0 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt (+0 -88)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+0 -45)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/util/ServiceTypeExtensionsTest.kt (+18 -126)
📝 ui/src/main/res/values/strings_non_localized.xml (+0 -4)

📄 Description

🎟️ Tracking

PM-24137
PM-24138

📔 Objective

This PR removes the simple-login-self-host-alias and anon-addy-self-host-alias feature flags.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5575 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/24/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-24137-PM-24138-remove-host-alias-flags` --- ### 📝 Commits (1) - [`baaa523`](https://github.com/bitwarden/android/commit/baaa5234883938cf819500676b1e93b2f513e597) PM-24137, PM-24138: Remove host alias feature flags ### 📊 Changes **11 files changed** (+44 additions, -416 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+0 -19) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+0 -6) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+23 -38) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+1 -76) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/util/ServiceTypeExtensions.kt` (+2 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+0 -6) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+0 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt` (+0 -88) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+0 -45) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/generator/util/ServiceTypeExtensionsTest.kt` (+18 -126) 📝 `ui/src/main/res/values/strings_non_localized.xml` (+0 -4) </details> ### 📄 Description ## 🎟️ Tracking [PM-24137](https://bitwarden.atlassian.net/browse/PM-24137) [PM-24138](https://bitwarden.atlassian.net/browse/PM-24138) ## 📔 Objective This PR removes the `simple-login-self-host-alias` and `anon-addy-self-host-alias` feature flags. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-24137]: https://bitwarden.atlassian.net/browse/PM-24137?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-24138]: https://bitwarden.atlassian.net/browse/PM-24138?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:16:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?