github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5550] [MERGED] [PM-23817] Move PM string to UI module and update Crowdin configuration #5859

New Issue
Closed
opened 2025-11-27 00:15:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:15:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5550
Author: @SaintPatrck
Created: 7/21/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-23817/pm-string-move-test

📝 Commits (1)

  • c1c48f6 Move string resource to UI module and update Crowdin configuration

📊 Changes

5 files changed (+24 additions, -4 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/PrivilegedAppsListScreen.kt (+2 -1)
📝 crowdin-bwpm.yml (+7 -3)
📝 ui/build.gradle.kts (+6 -0)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/resource/BitwardenResources.kt (+5 -0)
➕ ui/src/main/res/values/strings.xml (+4 -0)

📄 Description

🎟️ Tracking

PM-23817

📔 Objective

This commit moves the delete_x string resource from the app module to the ui module.

The following changes were made:

  • Added strings.xml to ui/src/main/res/values/ and defined delete_x string.
  • Updated PrivilegedAppsListScreen.kt to use BitwardenString.delete_x from the ui module.
  • Added BitwardenString typealias in BitwardenResources.kt for string resources in the UI module.
  • Updated crowdin-bwpm.yml to include the new path for UI module strings and adjusted the base path.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5550 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-23817/pm-string-move-test` --- ### 📝 Commits (1) - [`c1c48f6`](https://github.com/bitwarden/android/commit/c1c48f667e953941aa30a1361203c44f28d7ea97) Move string resource to UI module and update Crowdin configuration ### 📊 Changes **5 files changed** (+24 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/list/PrivilegedAppsListScreen.kt` (+2 -1) 📝 `crowdin-bwpm.yml` (+7 -3) 📝 `ui/build.gradle.kts` (+6 -0) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/resource/BitwardenResources.kt` (+5 -0) ➕ `ui/src/main/res/values/strings.xml` (+4 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-23817 ## 📔 Objective This commit moves the `delete_x` string resource from the `app` module to the `ui` module. The following changes were made: - Added `strings.xml` to `ui/src/main/res/values/` and defined `delete_x` string. - Updated `PrivilegedAppsListScreen.kt` to use `BitwardenString.delete_x` from the `ui` module. - Added `BitwardenString` typealias in `BitwardenResources.kt` for string resources in the UI module. - Updated `crowdin-bwpm.yml` to include the new path for UI module strings and adjusted the base path. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:15:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?