github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 18:43:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5445] [CLOSED] [PM-23147] Update styles.xml #5771

New Issue
Closed
opened 2025-11-27 00:14:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:14:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5445
Author: @nash268
Created: 6/29/2025
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/src/main/res/values/styles.xml (+1 -1)

📄 Description

<item name="android:windowLayoutInDisplayCutoutMode">always</item>

Android 10 (API level 29) compatibility issue. changed to default

🎟️ Tracking

https://github.com/bitwarden/android/issues/5442

📔 Objective

fix Android 10 compatibility issue

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5445 **Author:** [@nash268](https://github.com/nash268) **Created:** 6/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`9d05b48`](https://github.com/bitwarden/android/commit/9d05b483dbc14fa8f5d5ce4a557d419206afeb25) Update styles.xml ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/res/values/styles.xml` (+1 -1) </details> ### 📄 Description `<item name="android:windowLayoutInDisplayCutoutMode">always</item>` Android 10 (API level 29) compatibility issue. changed to default ## 🎟️ Tracking https://github.com/bitwarden/android/issues/5442 ## 📔 Objective fix Android 10 compatibility issue ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:14:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5771
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?