github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #4043] [MERGED] PM-12667 Final change, update the image files #57388

New Issue
Closed
opened 2026-05-10 22:31:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-10 22:31:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4043
Author: @dseverns-livefront
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/8/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-12667-update-image-assets

📝 Commits (2)

📊 Changes

28 files changed (+959 additions, -647 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/blockautofill/BlockAutoFillScreen.kt (+8 -19)
📝 app/src/main/res/drawable-night/account_setup.xml (+48 -55)
➕ app/src/main/res/drawable-night/blocked_uri.xml (+38 -0)
📝 app/src/main/res/drawable-night/img_setup_complete.xml (+39 -22)
📝 app/src/main/res/drawable-night/lock.xml (+22 -48)
📝 app/src/main/res/drawable-night/open_email.xml (+28 -34)
➕ app/src/main/res/drawable-night/pending_requests.xml (+76 -0)
📝 app/src/main/res/drawable-night/vault.xml (+42 -42)
➕ app/src/main/res/drawable-night/welcome_1.xml (+80 -0)
➕ app/src/main/res/drawable-night/welcome_2.xml (+28 -0)
➕ app/src/main/res/drawable-night/welcome_3.xml (+40 -0)
➕ app/src/main/res/drawable-night/welcome_4.xml (+73 -0)
📝 app/src/main/res/drawable/account_setup.xml (+48 -55)
➕ app/src/main/res/drawable/blocked_uri.xml (+38 -0)
➖ app/src/main/res/drawable/ic_blocked_uri_background.xml (+0 -10)
➖ app/src/main/res/drawable/ic_blocked_uri_foreground.xml (+0 -31)
➖ app/src/main/res/drawable/ic_pending_requests.xml (+0 -33)
📝 app/src/main/res/drawable/img_setup_complete.xml (+36 -19)
📝 app/src/main/res/drawable/lock.xml (+22 -48)

...and 8 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12667

📔 Objective

  • update existing image files to match v3 designs

📸 Screenshots

https://github.com/user-attachments/assets/c105c935-447a-48ae-b467-f01d606e1b58

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4043 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-12667-update-image-assets` --- ### 📝 Commits (2) - [`5086cb6`](https://github.com/bitwarden/android/commit/5086cb6ddd7db5b4c16daca43af7ae169b4d55b5) PM-12667 update image assets - [`8a0b8a8`](https://github.com/bitwarden/android/commit/8a0b8a8f507807154ae0ee9a1d1816af334a4713) Fix tests ### 📊 Changes **28 files changed** (+959 additions, -647 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/pendingrequests/PendingRequestsScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/blockautofill/BlockAutoFillScreen.kt` (+8 -19) 📝 `app/src/main/res/drawable-night/account_setup.xml` (+48 -55) ➕ `app/src/main/res/drawable-night/blocked_uri.xml` (+38 -0) 📝 `app/src/main/res/drawable-night/img_setup_complete.xml` (+39 -22) 📝 `app/src/main/res/drawable-night/lock.xml` (+22 -48) 📝 `app/src/main/res/drawable-night/open_email.xml` (+28 -34) ➕ `app/src/main/res/drawable-night/pending_requests.xml` (+76 -0) 📝 `app/src/main/res/drawable-night/vault.xml` (+42 -42) ➕ `app/src/main/res/drawable-night/welcome_1.xml` (+80 -0) ➕ `app/src/main/res/drawable-night/welcome_2.xml` (+28 -0) ➕ `app/src/main/res/drawable-night/welcome_3.xml` (+40 -0) ➕ `app/src/main/res/drawable-night/welcome_4.xml` (+73 -0) 📝 `app/src/main/res/drawable/account_setup.xml` (+48 -55) ➕ `app/src/main/res/drawable/blocked_uri.xml` (+38 -0) ➖ `app/src/main/res/drawable/ic_blocked_uri_background.xml` (+0 -10) ➖ `app/src/main/res/drawable/ic_blocked_uri_foreground.xml` (+0 -31) ➖ `app/src/main/res/drawable/ic_pending_requests.xml` (+0 -33) 📝 `app/src/main/res/drawable/img_setup_complete.xml` (+36 -19) 📝 `app/src/main/res/drawable/lock.xml` (+22 -48) _...and 8 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-12667 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - update existing image files to match v3 designs <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/c105c935-447a-48ae-b467-f01d606e1b58 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-10 22:31:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#57388