github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5400] [CLOSED] Brave 3rd party autofill #5735

New Issue
Closed
opened 2025-11-27 00:13:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:13:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5400
Author: @david-livefront
Created: 6/20/2025
Status: ❌ Closed

Base: main ← Head: brave-3rd-party-autofill

📝 Commits (2)

  • 15a23ab Rename Chrome Autofill to Browser Autofill
  • 1c85fa9 Support Brave as Browser with 3rd party Autofill support

📊 Changes

27 files changed (+333 additions, -289 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt (+9 -9)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/AutofillModule.kt (+5 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt (+12 -11)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillEnabledManager.kt (+22 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillEnabledManagerImpl.kt (+15 -11)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillManager.kt (+25 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillManagerImpl.kt (+15 -14)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManager.kt (+0 -22)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManager.kt (+0 -20)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/BrowserReleaseChannel.kt (+16 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/BrowserThirdPartyAutoFillData.kt (+18 -0)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeReleaseChannel.kt (+0 -14)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeThirdPartyAutoFillData.kt (+0 -17)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt (+3 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModel.kt (+26 -22)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/browser/BrowserAutofillSettingsCard.kt (+15 -14)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/browser/model/BrowserAutofillSettingsOption.kt (+58 -0)
➖ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/chrome/model/ChromeAutofillSettingsOption.kt (+0 -42)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/handlers/AutoFillHandlers.kt (+2 -2)

...and 7 more files

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR adds support for Brave as a browser that requires opt-in for 3rd part Autofill support.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5400 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `brave-3rd-party-autofill` --- ### 📝 Commits (2) - [`15a23ab`](https://github.com/bitwarden/android/commit/15a23ab7ca526b2a4b8495d65625046b775d334c) Rename Chrome Autofill to Browser Autofill - [`1c85fa9`](https://github.com/bitwarden/android/commit/1c85fa9d0173252f3f04a450707f1a76e8667533) Support Brave as Browser with 3rd party Autofill support ### 📊 Changes **27 files changed** (+333 additions, -289 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/ActivityAutofillModule.kt` (+9 -9) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/di/AutofillModule.kt` (+5 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt` (+12 -11) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillEnabledManager.kt` (+22 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillEnabledManagerImpl.kt` (+15 -11) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillManager.kt` (+25 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/BrowserThirdPartyAutofillManagerImpl.kt` (+15 -14) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillEnabledManager.kt` (+0 -22) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/chrome/ChromeThirdPartyAutofillManager.kt` (+0 -20) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/BrowserReleaseChannel.kt` (+16 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/BrowserThirdPartyAutoFillData.kt` (+18 -0) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeReleaseChannel.kt` (+0 -14) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/chrome/ChromeThirdPartyAutoFillData.kt` (+0 -17) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt` (+3 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModel.kt` (+26 -22) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/browser/BrowserAutofillSettingsCard.kt` (+15 -14) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/browser/model/BrowserAutofillSettingsOption.kt` (+58 -0) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/chrome/model/ChromeAutofillSettingsOption.kt` (+0 -42) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/handlers/AutoFillHandlers.kt` (+2 -2) _...and 7 more files_ </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR adds support for Brave as a browser that requires opt-in for 3rd part Autofill support. ## 📸 Screenshots | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/e2e09df2-b17e-45d0-bed2-093a35c709b7" width="300" /> | <img src="https://github.com/user-attachments/assets/a1b7be97-6ee1-4fb6-ac0e-e716bbca6c3f" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:13:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?