github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5389] [MERGED] [BRE-848] Add Workflow Permissions #5725

New Issue
Closed
opened 2025-11-27 00:13:17 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:13:17 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5389
Author: @pixman20
Created: 6/18/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @pixman20

Base: main ← Head: BRE-848-update-workflow-permissions

📝 Commits (2)

  • da32ddf BRE-848 Adding Workflow Permissions
  • 30a0ac0 Merge remote-tracking branch 'origin/main' into BRE-848-update-workflow-permissions

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 .github/workflows/publish-github-release.yml (+3 -1)
📝 .github/workflows/publish.yml (+2 -0)

📄 Description

🎟️ Tracking

BRE-848

📔 Objective

Adding permissions to all workflows not being updated by BRE-831
This will prepare for changing the org wide GitHub actions setting to contents:read and packages:read as the default permissions provided to workflows.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5389 **Author:** [@pixman20](https://github.com/pixman20) **Created:** 6/18/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@pixman20](https://github.com/pixman20) **Base:** `main` ← **Head:** `BRE-848-update-workflow-permissions` --- ### 📝 Commits (2) - [`da32ddf`](https://github.com/bitwarden/android/commit/da32ddfc0ff8fe05d3042669ff8ca56690e780fb) [BRE-848] Adding Workflow Permissions - [`30a0ac0`](https://github.com/bitwarden/android/commit/30a0ac0e3af32ef2f938eab1aa5b8ab594dab9c4) Merge remote-tracking branch 'origin/main' into BRE-848-update-workflow-permissions ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish-github-release.yml` (+3 -1) 📝 `.github/workflows/publish.yml` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking [BRE-848](https://bitwarden.atlassian.net/browse/BRE-848) ## 📔 Objective Adding permissions to all workflows not being updated by [BRE-831](https://bitwarden.atlassian.net/browse/BRE-831) This will prepare for changing the org wide GitHub actions setting to `contents:read` and `packages:read` as the default permissions provided to workflows. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [BRE-848]: https://bitwarden.atlassian.net/browse/BRE-848?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [BRE-831]: https://bitwarden.atlassian.net/browse/BRE-831?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:13:17 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5725
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?