github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-24 23:32:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #5350] [MERGED] [PM-22568] Change totp seed field to a password field #5691

New Issue
Closed
opened 2025-11-27 00:12:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:12:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5350
Author: @aj-rosado
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/13/2025
Merged by: @aj-rosado

Base: main ← Head: PM-22568/hide-totp-seed-key

📝 Commits (6)

  • c8c4a54 change otp seed field to a password field
  • 13e0f16 Added new test and fixed existing tests for VaultAddEditScreenTest
  • e63c9ff showing totp tooltip when creating an item
  • 1960c05 Merge branch 'main' into PM-22568/hide-totp-seed-key
  • 71a27bd Added tooltip to Totp field
  • 3af88b4 reverting tests to original

📊 Changes

2 files changed (+51 additions, -2 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+2 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+49 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22568

📔 Objective

TOTP seed should be protected just like login password.
Currently BitwardenPasswordField does not support tooltip, we are dropping it on this screen. (it is supported now)

📸 Screenshots

Edit item with protected TOTP field

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5350 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/13/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-22568/hide-totp-seed-key` --- ### 📝 Commits (6) - [`c8c4a54`](https://github.com/bitwarden/android/commit/c8c4a54298066db23a7a5ee7b9b17169c6caa551) change otp seed field to a password field - [`13e0f16`](https://github.com/bitwarden/android/commit/13e0f16dd028386561fccfbb5608818f73e9658d) Added new test and fixed existing tests for VaultAddEditScreenTest - [`e63c9ff`](https://github.com/bitwarden/android/commit/e63c9ffa68ba475ef64fe29a343981406277235b) showing totp tooltip when creating an item - [`1960c05`](https://github.com/bitwarden/android/commit/1960c05a031deea063f12b4c344f21499feb7a10) Merge branch 'main' into PM-22568/hide-totp-seed-key - [`71a27bd`](https://github.com/bitwarden/android/commit/71a27bd2e369259a93022cbb1b6465b528362b19) Added tooltip to Totp field - [`3af88b4`](https://github.com/bitwarden/android/commit/3af88b4bdda14555cd6aedb985115c3870b639bd) reverting tests to original ### 📊 Changes **2 files changed** (+51 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+2 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+49 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-22568 ## 📔 Objective TOTP seed should be protected just like login password. ~~Currently `BitwardenPasswordField` does not support tooltip, we are dropping it on this screen.~~ (it is supported now) ## 📸 Screenshots <img width="314" alt="Edit item with protected TOTP field" src="https://github.com/user-attachments/assets/430791e1-496c-46bf-a65e-ca0a8e9b7880"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:12:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5691
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?