github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5335] [MERGED] [PM-22461] Add About privileged apps screen #5680

New Issue
Closed
opened 2025-11-27 00:12:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:12:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5335
Author: @SaintPatrck
Created: 6/9/2025
Status: ✅ Merged
Merged: 6/12/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-22461/about-privileged-apps-screen

📝 Commits (1)

  • 508fdb3 [PM-22461] Add AboutPrivilegedAppsScreen

📊 Changes

15 files changed (+636 additions, -158 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsNavigation.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillNavigation.kt (+4 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt (+167 -158)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModel.kt (+47 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/handlers/AutoFillHandlers.kt (+98 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/about/AboutPrivilegedAppsNavigation.kt (+38 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/about/AboutPrivilegedAppsScreen.kt (+102 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlocked/VaultUnlockedNavigation.kt (+11 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarNavigation.kt (+4 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt (+4 -0)
📝 app/src/main/res/values/strings.xml (+10 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt (+41 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModelTest.kt (+28 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/AboutPrivilegedAppsScreenTest.kt (+79 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreenTest.kt (+1 -0)

📄 Description

🎟️ Tracking

PM-22461

📔 Objective

This commit introduces the AboutPrivilegedAppsScreen, which provides information about privileged applications in the context of autofill and passkey operations.

The new screen explains the different trust levels for applications:

  • Trusted by You
  • Trusted by the Community
  • Trusted by Google

This screen is accessible from the AutoFill settings screen via a new "Privileged apps" row and a help icon if the UserManagedPrivilegedApps feature flag is enabled.

The following changes are included:

  • Added AboutPrivilegedAppsScreen.kt with the UI for the new screen.
  • Added AboutPrivilegedAppsNavigation.kt for navigation to and from the screen.
  • Updated SettingsNavigation.kt to include the new destination.
  • Updated AutoFillScreen.kt to display the "Privileged apps" row and help icon when the feature flag is enabled.
  • Updated AutoFillViewModel.kt to handle navigation to the new screen and to observe the UserManagedPrivilegedApps feature flag.
  • Added new string resources for the screen content and labels.
  • Added UI tests for AboutPrivilegedAppsScreen and updated tests for AutoFillScreen and AutoFillViewModel.
  • Introduced AutoFillHandlers.kt to centralize action handling for the AutoFill screen.

📸 Screenshots

image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5335 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 6/9/2025 **Status:** ✅ Merged **Merged:** 6/12/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-22461/about-privileged-apps-screen` --- ### 📝 Commits (1) - [`508fdb3`](https://github.com/bitwarden/android/commit/508fdb30b5f5406a2c141655dc8ad2262df7110b) [PM-22461] Add AboutPrivilegedAppsScreen ### 📊 Changes **15 files changed** (+636 additions, -158 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsNavigation.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillNavigation.kt` (+4 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt` (+167 -158) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModel.kt` (+47 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/handlers/AutoFillHandlers.kt` (+98 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/about/AboutPrivilegedAppsNavigation.kt` (+38 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/about/AboutPrivilegedAppsScreen.kt` (+102 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlocked/VaultUnlockedNavigation.kt` (+11 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarNavigation.kt` (+4 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt` (+4 -0) 📝 `app/src/main/res/values/strings.xml` (+10 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreenTest.kt` (+41 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModelTest.kt` (+28 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/privilegedapps/AboutPrivilegedAppsScreenTest.kt` (+79 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreenTest.kt` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-22461 ## 📔 Objective This commit introduces the AboutPrivilegedAppsScreen, which provides information about privileged applications in the context of autofill and passkey operations. The new screen explains the different trust levels for applications: - Trusted by You - Trusted by the Community - Trusted by Google This screen is accessible from the AutoFill settings screen via a new "Privileged apps" row and a help icon if the `UserManagedPrivilegedApps` feature flag is enabled. The following changes are included: - Added `AboutPrivilegedAppsScreen.kt` with the UI for the new screen. - Added `AboutPrivilegedAppsNavigation.kt` for navigation to and from the screen. - Updated `SettingsNavigation.kt` to include the new destination. - Updated `AutoFillScreen.kt` to display the "Privileged apps" row and help icon when the feature flag is enabled. - Updated `AutoFillViewModel.kt` to handle navigation to the new screen and to observe the `UserManagedPrivilegedApps` feature flag. - Added new string resources for the screen content and labels. - Added UI tests for `AboutPrivilegedAppsScreen` and updated tests for `AutoFillScreen` and `AutoFillViewModel`. - Introduced `AutoFillHandlers.kt` to centralize action handling for the AutoFill screen. ## 📸 Screenshots <img width="365" alt="image" src="https://github.com/user-attachments/assets/70f7b73a-bda7-4a92-afe7-ae06d401fe75" /> <img width="365" alt="image" src="https://github.com/user-attachments/assets/2dc17090-7095-453c-9e42-7a735127ed86" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:12:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5680
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?