github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 23:16:54 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3082] [MERGED] [PM-6468] Implement copy TOTP after using Passkey if needed #56765

New Issue
Closed
opened 2026-05-10 19:47:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-10 19:47:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3082
Author: @fedemkr
Created: 3/14/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: vault/pm-6468/copy-totp-on-passkey

📝 Commits (1)

  • 2728772 PM-6468 Implemented copy TOTP if needed after using a Fido2 credential. Also added the Fido2MediatorService to have one point to interact with the authentication and also to add any new logic we need.

📊 Changes

14 files changed (+129 additions, -40 deletions)

View changed files

📝 src/Core/Abstractions/ICipherService.cs (+1 -0)
➖ src/Core/Abstractions/IFido2AuthenticationService.cs (+0 -9)
➕ src/Core/Abstractions/IFido2MediatorService.cs (+14 -0)
📝 src/Core/Services/CipherService.cs (+22 -0)
➖ src/Core/Services/Fido2AuthenticationService.cs (+0 -18)
📝 src/Core/Services/Fido2AuthenticatorService.cs (+2 -1)
📝 src/Core/Services/Fido2ClientService.cs (+2 -1)
➕ src/Core/Services/Fido2MediatorService.cs (+60 -0)
📝 src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionResult.cs (+5 -1)
📝 src/Core/Utilities/Fido2/Fido2ClientAssertCredentialResult.cs (+7 -0)
📝 src/Core/Utilities/ServiceContainer.cs (+3 -3)
📝 src/iOS.Autofill/CredentialProviderViewController.Passkeys.cs (+3 -3)
📝 src/iOS.Autofill/LoginListViewController.cs (+2 -2)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+8 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Copy TOTP after using Passkey if exist and if the user has it enabled.

Code changes

  • CipherService: Implemented TOTP copy with the corresponding verifications
  • Fido2MediatorService: Added this class to mediate between the callers and the Fido2ClientService and Fido2AuthenticationService adding additional logic like copying the TOTP.
  • Fido2...: Added the CipherView to the result so we can use that to make the verifications and copy the TOTP
  • Removed some classes that are no longer used

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3082 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6468/copy-totp-on-passkey` --- ### 📝 Commits (1) - [`2728772`](https://github.com/bitwarden/android/commit/2728772610c483426716871208ddef461ebeeae1) PM-6468 Implemented copy TOTP if needed after using a Fido2 credential. Also added the Fido2MediatorService to have one point to interact with the authentication and also to add any new logic we need. ### 📊 Changes **14 files changed** (+129 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/ICipherService.cs` (+1 -0) ➖ `src/Core/Abstractions/IFido2AuthenticationService.cs` (+0 -9) ➕ `src/Core/Abstractions/IFido2MediatorService.cs` (+14 -0) 📝 `src/Core/Services/CipherService.cs` (+22 -0) ➖ `src/Core/Services/Fido2AuthenticationService.cs` (+0 -18) 📝 `src/Core/Services/Fido2AuthenticatorService.cs` (+2 -1) 📝 `src/Core/Services/Fido2ClientService.cs` (+2 -1) ➕ `src/Core/Services/Fido2MediatorService.cs` (+60 -0) 📝 `src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionResult.cs` (+5 -1) 📝 `src/Core/Utilities/Fido2/Fido2ClientAssertCredentialResult.cs` (+7 -0) 📝 `src/Core/Utilities/ServiceContainer.cs` (+3 -3) 📝 `src/iOS.Autofill/CredentialProviderViewController.Passkeys.cs` (+3 -3) 📝 `src/iOS.Autofill/LoginListViewController.cs` (+2 -2) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+8 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Copy TOTP after using Passkey if exist and if the user has it enabled. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherService:** Implemented TOTP copy with the corresponding verifications * **Fido2MediatorService:** Added this class to mediate between the callers and the `Fido2ClientService` and `Fido2AuthenticationService` adding additional logic like copying the TOTP. * **Fido2...:** Added the `CipherView` to the result so we can use that to make the verifications and copy the TOTP * Removed some classes that are no longer used ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-10 19:47:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#56765
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?