github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3001] [MERGED] Fix for Android builds #56699

New Issue
Closed
opened 2026-05-10 19:40:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-10 19:40:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3001
Author: @mpbw2
Created: 2/12/2024
Status: ✅ Merged
Merged: 2/12/2024
Merged by: @mpbw2

Base: main ← Head: buildfix-ut-enable

📝 Commits (2)

  • 8e5d808 enable unit test flag
  • 28fae64 revert UT flag and modify flags in ThemeManager

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/Core/Utilities/ThemeManager.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Nested compiler directives to prevent context errors in ThemeManager preventing tests from running

Code changes

  • ThemeManager.cs: Nested compiler directives to prevent context errors preventing tests from running

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3001 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/12/2024 **Status:** ✅ Merged **Merged:** 2/12/2024 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `main` ← **Head:** `buildfix-ut-enable` --- ### 📝 Commits (2) - [`8e5d808`](https://github.com/bitwarden/android/commit/8e5d8088f95815c26e94d74145ee4808142c4905) enable unit test flag - [`28fae64`](https://github.com/bitwarden/android/commit/28fae644235e9350a16318d516c7a917be73f511) revert UT flag and modify flags in ThemeManager ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Utilities/ThemeManager.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Nested compiler directives to prevent context errors in `ThemeManager` preventing tests from running ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ThemeManager.cs:** Nested compiler directives to prevent context errors preventing tests from running ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-10 19:40:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#56699