github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5314] [CLOSED] Agalles/automate android fastlane patch #5667

New Issue
Closed
opened 2025-11-27 00:11:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:11:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5314
Author: @AmyLGalles
Created: 6/5/2025
Status: ❌ Closed

Base: agalles/automate-android ← Head: agalles/automate-android-fastlane-patch

📝 Commits (10+)

  • 1acc1a8 [PM-21851] Migrate RememberVectorPainter to ui module (#5233)
  • d1a8cbf Bump authenticatorbridge to 1.0.1 (#5230)
  • c145451 PM-21879: Move SpanStyleUtil and StringResExtensions to UI module (#5238)
  • 4216f3f Rename all java source dirs to kotlin (#5239)
  • c9d4d35 [PM-21851] Use rememberVectorPainter from platform UI in Authenticator (#5240)
  • 000a7d1 PM-17660: Add additional context for the sync feature (#5243)
  • d5c0412 [PM-21888] Migrate icon buttons to ui module (#5241)
  • 9deb39d adding release notes to Fastlane
  • 6d976be [PM-21577] Handle organization limitItemDeletion from sync response. (#5244)
  • 3551e75 PM-16705: Improve the node validation logic (#5250)

📊 Changes

1684 files changed (+7027 additions, -7531 deletions)

View changed files

➖ .github/workflows/crowdin-pull-authenticator.yml (+0 -59)
📝 .github/workflows/crowdin-pull.yml (+21 -11)
➖ .github/workflows/crowdin-push-authenticator.yml (+0 -32)
📝 .github/workflows/crowdin-push.yml (+18 -7)
➕ .github/workflows/publish-github-release.yml (+12 -0)
➕ .github/workflows/publish.yml (+142 -0)
➕ .github/workflows/test-device.yml (+16 -0)
📝 Gemfile.lock (+5 -5)
📝 app/build.gradle.kts (+1 -1)
📝 app/libs/authenticatorbridge-1.0.1-release.aar (+0 -0)
📝 app/src/fdroid/kotlin/com/x8bit/bitwarden/data/platform/manager/LogsManagerImpl.kt (+0 -0)
📝 app/src/fdroid/kotlin/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt (+0 -0)
📝 app/src/main/AndroidManifest.xml (+4 -2)
➖ app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/OrganizationDomainSsoDetailsResult.kt (+0 -28)
➖ app/src/main/java/com/x8bit/bitwarden/ui/platform/util/SpanStyleUtil.kt (+0 -31)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AccessibilityActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackViewModel.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyActivity.kt (+0 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyViewModel.kt (+0 -0)

...and 80 more files

📄 Description

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5314 **Author:** [@AmyLGalles](https://github.com/AmyLGalles) **Created:** 6/5/2025 **Status:** ❌ Closed **Base:** `agalles/automate-android` ← **Head:** `agalles/automate-android-fastlane-patch` --- ### 📝 Commits (10+) - [`1acc1a8`](https://github.com/bitwarden/android/commit/1acc1a87a6411040690c0357c2e35fbe670d93d0) [PM-21851] Migrate RememberVectorPainter to ui module (#5233) - [`d1a8cbf`](https://github.com/bitwarden/android/commit/d1a8cbf59f5efe3d9596003755cadb48a6e3a70b) Bump authenticatorbridge to 1.0.1 (#5230) - [`c145451`](https://github.com/bitwarden/android/commit/c14545107d8daa5c799b4bb871761ec76c9c0658) PM-21879: Move SpanStyleUtil and StringResExtensions to UI module (#5238) - [`4216f3f`](https://github.com/bitwarden/android/commit/4216f3f5a028b5d4e7bf3d76dc8120d750a27478) Rename all `java` source dirs to `kotlin` (#5239) - [`c9d4d35`](https://github.com/bitwarden/android/commit/c9d4d35f07a7a504f32d7ebc2b3b165dbeeaee12) [PM-21851] Use `rememberVectorPainter` from platform UI in Authenticator (#5240) - [`000a7d1`](https://github.com/bitwarden/android/commit/000a7d141e7502d13cc84365fd100bf3144392bb) PM-17660: Add additional context for the sync feature (#5243) - [`d5c0412`](https://github.com/bitwarden/android/commit/d5c04123d919dfa393013590df817b578b5f2578) [PM-21888] Migrate icon buttons to ui module (#5241) - [`9deb39d`](https://github.com/bitwarden/android/commit/9deb39d7451a41a8f969bcfad3000cacebe28d60) adding release notes to Fastlane - [`6d976be`](https://github.com/bitwarden/android/commit/6d976bea4cdc6e7186be1895288a6e6e44d5f1fa) [PM-21577] Handle organization limitItemDeletion from sync response. (#5244) - [`3551e75`](https://github.com/bitwarden/android/commit/3551e755969dcb0403dab7e73e5501e80c92b01d) PM-16705: Improve the node validation logic (#5250) ### 📊 Changes **1684 files changed** (+7027 additions, -7531 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/crowdin-pull-authenticator.yml` (+0 -59) 📝 `.github/workflows/crowdin-pull.yml` (+21 -11) ➖ `.github/workflows/crowdin-push-authenticator.yml` (+0 -32) 📝 `.github/workflows/crowdin-push.yml` (+18 -7) ➕ `.github/workflows/publish-github-release.yml` (+12 -0) ➕ `.github/workflows/publish.yml` (+142 -0) ➕ `.github/workflows/test-device.yml` (+16 -0) 📝 `Gemfile.lock` (+5 -5) 📝 `app/build.gradle.kts` (+1 -1) 📝 `app/libs/authenticatorbridge-1.0.1-release.aar` (+0 -0) 📝 `app/src/fdroid/kotlin/com/x8bit/bitwarden/data/platform/manager/LogsManagerImpl.kt` (+0 -0) 📝 `app/src/fdroid/kotlin/com/x8bit/bitwarden/ui/platform/manager/review/AppReviewManagerImpl.kt` (+0 -0) 📝 `app/src/main/AndroidManifest.xml` (+4 -2) ➖ `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/OrganizationDomainSsoDetailsResult.kt` (+0 -28) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/platform/util/SpanStyleUtil.kt` (+0 -31) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AccessibilityActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AuthCallbackViewModel.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyActivity.kt` (+0 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/AutofillTotpCopyViewModel.kt` (+0 -0) _...and 80 more files_ </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:11:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5667
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?