github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5286] [MERGED] [PM-21475] Remove deprecated SSO details endpoint feature flag #5642

New Issue
Closed
opened 2025-11-27 00:11:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:11:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5286
Author: @SaintPatrck
Created: 5/29/2025
Status: ✅ Merged
Merged: 5/30/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-21475/remove-verified-sso-domain-endpoint-feature-flag

📝 Commits (1)

  • af38ca3 [PM-21475] Remove deprecated SSO details endpoint feature flag

📊 Changes

18 files changed (+80 additions, -410 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt (+0 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+0 -20)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt (+0 -3)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/OrganizationDomainSsoDetailsResult.kt (+0 -28)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+0 -9)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt (+8 -88)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+0 -2)
📝 app/src/main/res/values/strings.xml (+0 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+0 -36)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+0 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModelTest.kt (+72 -97)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+0 -2)
📝 network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedOrganizationApi.kt (+0 -9)
➖ network/src/main/kotlin/com/bitwarden/network/model/OrganizationDomainSsoDetailsRequestJson.kt (+0 -14)
➖ network/src/main/kotlin/com/bitwarden/network/model/OrganizationDomainSsoDetailsResponseJson.kt (+0 -26)
📝 network/src/main/kotlin/com/bitwarden/network/service/OrganizationService.kt (+0 -8)
📝 network/src/main/kotlin/com/bitwarden/network/service/OrganizationServiceImpl.kt (+0 -12)
📝 network/src/test/kotlin/com/bitwarden/network/service/OrganizationServiceTest.kt (+0 -41)

📄 Description

🎟️ Tracking

PM-21475

📔 Objective

The VerifiedSsoDomainEndpoint feature flag has been removed as the new endpoint is now the default and the old endpoint is no longer supported.

This change involves:

  • Removing the VerifiedSsoDomainEndpoint data object from FlagKey.kt.
  • Removing the feature flag from the debug menu in FeatureFlagListItems.kt.
  • Removing the featureFlagManager dependency from AuthRepositoryImpl.kt.
  • Updating EnterpriseSignOnViewModel.kt and its corresponding test file to remove logic related to the deprecated feature flag and always use the verified SSO domain details endpoint.
  • Removing unused internal actions and handlers related to the old SSO details endpoint in EnterpriseSignOnViewModel.kt.
  • The OrganizationDomainSsoDetails data models and related API calls were removed as they are no longer in use.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5286 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 5/30/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-21475/remove-verified-sso-domain-endpoint-feature-flag` --- ### 📝 Commits (1) - [`af38ca3`](https://github.com/bitwarden/android/commit/af38ca337ddda5fc8de109db93650d258ba2129b) [PM-21475] Remove deprecated SSO details endpoint feature flag ### 📊 Changes **18 files changed** (+80 additions, -410 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt` (+0 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+0 -20) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt` (+0 -3) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/model/OrganizationDomainSsoDetailsResult.kt` (+0 -28) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+0 -9) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModel.kt` (+8 -88) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+0 -2) 📝 `app/src/main/res/values/strings.xml` (+0 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+0 -36) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+0 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/enterprisesignon/EnterpriseSignOnViewModelTest.kt` (+72 -97) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+0 -2) 📝 `network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedOrganizationApi.kt` (+0 -9) ➖ `network/src/main/kotlin/com/bitwarden/network/model/OrganizationDomainSsoDetailsRequestJson.kt` (+0 -14) ➖ `network/src/main/kotlin/com/bitwarden/network/model/OrganizationDomainSsoDetailsResponseJson.kt` (+0 -26) 📝 `network/src/main/kotlin/com/bitwarden/network/service/OrganizationService.kt` (+0 -8) 📝 `network/src/main/kotlin/com/bitwarden/network/service/OrganizationServiceImpl.kt` (+0 -12) 📝 `network/src/test/kotlin/com/bitwarden/network/service/OrganizationServiceTest.kt` (+0 -41) </details> ### 📄 Description ## 🎟️ Tracking PM-21475 ## 📔 Objective The `VerifiedSsoDomainEndpoint` feature flag has been removed as the new endpoint is now the default and the old endpoint is no longer supported. This change involves: - Removing the `VerifiedSsoDomainEndpoint` data object from `FlagKey.kt`. - Removing the feature flag from the debug menu in `FeatureFlagListItems.kt`. - Removing the `featureFlagManager` dependency from `AuthRepositoryImpl.kt`. - Updating `EnterpriseSignOnViewModel.kt` and its corresponding test file to remove logic related to the deprecated feature flag and always use the verified SSO domain details endpoint. - Removing unused internal actions and handlers related to the old SSO details endpoint in `EnterpriseSignOnViewModel.kt`. - The OrganizationDomainSsoDetails data models and related API calls were removed as they are no longer in use. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:11:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?