github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5283] [MERGED] [PM-20146] Remove native-create-account-flow feature flag #5639

New Issue
Closed
opened 2025-11-27 00:11:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:11:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5283
Author: @andrebispo5
Created: 5/29/2025
Status: ✅ Merged
Merged: 5/29/2025
Merged by: @andrebispo5

Base: main ← Head: pm-20146/remove-native-create-account-flow-flag

📝 Commits (5)

  • 6cbaa3a [PM-20146] Remove references from native-create-account-flow flag. Remove logic associated with it.
  • e64619a [PM-20146] Update tests.
  • 858ea67 [PM-20146] Remove unused string resource.
  • dbbf231 [PM-20146] Fix PR with suggestions.
  • 0f5cc99 Merge branch 'main' into pm-20146/remove-native-create-account-flow-flag

📊 Changes

22 files changed (+137 additions, -677 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+0 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt (+0 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt (+0 -14)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt (+0 -9)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+43 -138)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+0 -36)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+11 -44)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModel.kt (+0 -27)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuScreen.kt (+0 -7)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt (+0 -2)
📝 app/src/main/res/values/strings.xml (+0 -2)
📝 app/src/main/res/values/strings_non_localized.xml (+0 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+2 -71)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt (+0 -24)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt (+0 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/DebugMenuRepositoryTest.kt (+0 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt (+61 -121)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt (+1 -18)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt (+0 -10)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModelTest.kt (+18 -109)

...and 2 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20146

📔 Objective

Remove native-create-account-flow feature flag from the codebase. Update existing logic and tests to reflect this removal.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5283 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 5/29/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-20146/remove-native-create-account-flow-flag` --- ### 📝 Commits (5) - [`6cbaa3a`](https://github.com/bitwarden/android/commit/6cbaa3a741079b395ac942567333f9b311755f27) [PM-20146] Remove references from native-create-account-flow flag. Remove logic associated with it. - [`e64619a`](https://github.com/bitwarden/android/commit/e64619a3060d1275c8fc5c44767fcebcad1d55d8) [PM-20146] Update tests. - [`858ea67`](https://github.com/bitwarden/android/commit/858ea6797b1661e9ca36425b9bb88ba221e778e9) [PM-20146] Remove unused string resource. - [`dbbf231`](https://github.com/bitwarden/android/commit/dbbf231996df44cf24d09637bf7e1156d085d485) [PM-20146] Fix PR with suggestions. - [`0f5cc99`](https://github.com/bitwarden/android/commit/0f5cc99e87b65495737081dcdea7abc27a98d41c) Merge branch 'main' into pm-20146/remove-native-create-account-flow-flag ### 📊 Changes **22 files changed** (+137 additions, -677 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+0 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt` (+0 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt` (+0 -14) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt` (+0 -9) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+43 -138) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+0 -36) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+11 -44) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModel.kt` (+0 -27) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuScreen.kt` (+0 -7) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/components/FeatureFlagListItems.kt` (+0 -2) 📝 `app/src/main/res/values/strings.xml` (+0 -2) 📝 `app/src/main/res/values/strings_non_localized.xml` (+0 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+2 -71) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt` (+0 -24) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FlagKeyTest.kt` (+0 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/DebugMenuRepositoryTest.kt` (+0 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt` (+61 -121) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt` (+1 -18) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt` (+0 -10) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationViewModelTest.kt` (+18 -109) _...and 2 more files_ </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-20146 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Remove `native-create-account-flow` feature flag from the codebase. Update existing logic and tests to reflect this removal. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:11:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5639
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?