github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5276] [MERGED] [PM-21577] Fix delete button not showing bug #5633

New Issue
Closed
opened 2025-11-27 00:11:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:11:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5276
Author: @andrebispo5
Created: 5/28/2025
Status: ✅ Merged
Merged: 5/29/2025
Merged by: @andrebispo5

Base: main ← Head: pm-21577/fix-delete-permission-bug

📝 Commits (5)

  • c54c6e7 [PM-21577] Fix bug where chain was not returning the expected value.
  • 537e68d [PM-21577] Fix logic for delete permission and improved tests.
  • ab3eb8b [PM-21577] Fix for empty correlation.
  • cc89e76 [PM-21577] Performance improvement.
  • 015b43e Merge branch 'main' into pm-21577/fix-delete-permission-bug

📊 Changes

2 files changed (+31 additions, -18 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensions.kt (+12 -17)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensionsTest.kt (+19 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21577

📔 Objective

Fixed bug where chain logic was not returning the expected value.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5276 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/28/2025 **Status:** ✅ Merged **Merged:** 5/29/2025 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-21577/fix-delete-permission-bug` --- ### 📝 Commits (5) - [`c54c6e7`](https://github.com/bitwarden/android/commit/c54c6e797be42da70d02e7665bea0aadacb89998) [PM-21577] Fix bug where chain was not returning the expected value. - [`537e68d`](https://github.com/bitwarden/android/commit/537e68dc66510c50546ac41b494e8209743e3333) [PM-21577] Fix logic for delete permission and improved tests. - [`ab3eb8b`](https://github.com/bitwarden/android/commit/ab3eb8be804b3b4d24a3698dcef008e2af6748a4) [PM-21577] Fix for empty correlation. - [`cc89e76`](https://github.com/bitwarden/android/commit/cc89e76db6948b12252bd21c1c0734d0e26bfad9) [PM-21577] Performance improvement. - [`015b43e`](https://github.com/bitwarden/android/commit/015b43e6017a0503376d66529d0d77df2e595215) Merge branch 'main' into pm-21577/fix-delete-permission-bug ### 📊 Changes **2 files changed** (+31 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensions.kt` (+12 -17) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/util/CollectionViewExtensionsTest.kt` (+19 -1) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-21577 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Fixed bug where chain logic was not returning the expected value. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:11:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5633
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?