github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-26 22:04:07 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2313] [MERGED] [PS-2324] Add honorific title "Mx" #56251

New Issue
Closed
opened 2026-05-10 18:57:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-10 18:57:17 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2313
Author: @djsmith85
Created: 1/21/2023
Status: ✅ Merged
Merged: 1/23/2023
Merged by: @djsmith85

Base: master ← Head: PS-2324-add-honorific-title-mx

📝 Commits (1)

  • e7abfec [PS-2324] Add honorific title mx

📊 Changes

3 files changed (+16 additions, -1 deletions)

View changed files

📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+1 -0)
📝 src/App/Resources/AppResources.Designer.cs (+12 -1)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add the honorific title "Mx" as an option in the identity title.

Code changes

  • src/App/Resources/AppResources.resx: Define "Mx" as a string resource
  • src/App/Resources/AppResources.Designer.cs: Declare method to return string from AppResources.resx
  • src/App/Pages/Vault/CipherAddEditPageViewModel.cs: Add "Mx" as an option in the identity title selection

Screenshots

Android:
Android Mx titleAndroid Mx title selector

iOS:
iOS Mx title editiOS Mx title view

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2313 **Author:** [@djsmith85](https://github.com/djsmith85) **Created:** 1/21/2023 **Status:** ✅ Merged **Merged:** 1/23/2023 **Merged by:** [@djsmith85](https://github.com/djsmith85) **Base:** `master` ← **Head:** `PS-2324-add-honorific-title-mx` --- ### 📝 Commits (1) - [`e7abfec`](https://github.com/bitwarden/android/commit/e7abfecfc4df44bf81952d01728ee1793aa2d146) [PS-2324] Add honorific title mx ### 📊 Changes **3 files changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+1 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -1) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Add the honorific title "Mx" as an option in the identity title. ## Code changes * **src/App/Resources/AppResources.resx:** Define "Mx" as a string resource * **src/App/Resources/AppResources.Designer.cs:** Declare method to return string from AppResources.resx * **src/App/Pages/Vault/CipherAddEditPageViewModel.cs:** Add "Mx" as an option in the identity title selection ## Screenshots Android: <img width="314" alt="Android Mx title" src="https://user-images.githubusercontent.com/109146700/214027983-397a5a3f-e3d9-44d0-aa8c-b64635143e96.png"><img width="314" alt="Android Mx title selector" src="https://user-images.githubusercontent.com/109146700/214027989-0b3d3bd8-b4a9-4fa9-8025-9b08ca6d616c.png"> iOS: <img width="314" alt="iOS Mx title edit" src="https://user-images.githubusercontent.com/109146700/214028604-fcc42e3e-4c03-4b1d-9f1e-8251bfc1b97b.png"><img width="314" alt="iOS Mx title view" src="https://user-images.githubusercontent.com/109146700/214028607-a770e02b-c7bb-47b8-b0e4-96dca9b9191c.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-10 18:57:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#56251