github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5256] [MERGED] [BRE-768] Automate Google Play publishing #5617

New Issue
Closed
opened 2025-11-27 00:10:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:10:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5256
Author: @AmyLGalles
Created: 5/23/2025
Status: ✅ Merged
Merged: 7/21/2025
Merged by: @AmyLGalles

Base: main ← Head: agalles/automate-android

📝 Commits (10+)

  • ebd4eac restore working version of android automation
  • 2e48d66 Update tracks for testing
  • 2e2aa3f Fix track_promote_release_status
  • 08e9b00 Add track inputs for testing
  • e7728e8 enable uploads of old releases
  • d8f3572 resolve merge conflicts
  • 1846201 rename publish workflow
  • b7b438c log inputs to job summary
  • 2f3c3a0 force change to reopen PR
  • 299764a temporarily renaming

📊 Changes

4 files changed (+345 additions, -7 deletions)

View changed files

📝 .github/workflows/publish-store.yml (+137 -7)
📝 fastlane/Fastfile (+73 -0)
➕ fastlane/patches/supply_custom_promote.rb (+97 -0)
➕ fastlane/patches/supply_custom_promote_config.rb (+38 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-768

Contains two patch files supply_custom_promote_config.rb and supply_custom_promote.rb that fix an issue where Fastlane 'Supply' doesn't recognize previous builds when promoting to another track.
Source: https://github.com/artsy/eigen/pull/10262
Author:: Brian Beckerle (@brainbicycle)

📔 Objective

Creating a workflow to trigger new lanes in Fastfile to automate releases of Android Authenticator and Password Manager.
Langugages are different for the two apps because authenticator only has English release notes so far. This can be changed if we want to fix it in the future.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5256 **Author:** [@AmyLGalles](https://github.com/AmyLGalles) **Created:** 5/23/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@AmyLGalles](https://github.com/AmyLGalles) **Base:** `main` ← **Head:** `agalles/automate-android` --- ### 📝 Commits (10+) - [`ebd4eac`](https://github.com/bitwarden/android/commit/ebd4eac7695e50e08169630e609282c72898796a) restore working version of android automation - [`2e48d66`](https://github.com/bitwarden/android/commit/2e48d66edd3ac26a1a6747c1229fe438d370e52d) Update tracks for testing - [`2e2aa3f`](https://github.com/bitwarden/android/commit/2e2aa3f083dc00365fbbdbd1f81cc65a1c6fdae5) Fix track_promote_release_status - [`08e9b00`](https://github.com/bitwarden/android/commit/08e9b006b2cc4ec77c44419977d29bdab75c2f33) Add track inputs for testing - [`e7728e8`](https://github.com/bitwarden/android/commit/e7728e851aace0956e4a53f9a309312dd569d926) enable uploads of old releases - [`d8f3572`](https://github.com/bitwarden/android/commit/d8f3572c7835ad25d050a9234617849f8226ede9) resolve merge conflicts - [`1846201`](https://github.com/bitwarden/android/commit/18462010aa3196022327b3c4bbaec2344c82a5d8) rename publish workflow - [`b7b438c`](https://github.com/bitwarden/android/commit/b7b438caf780cec6e869450dec906260f6535ee4) log inputs to job summary - [`2f3c3a0`](https://github.com/bitwarden/android/commit/2f3c3a0418f67438dedeedfe9ea9848432a7b49e) force change to reopen PR - [`299764a`](https://github.com/bitwarden/android/commit/299764a7a0254c60856e2acdec33357c6268be25) temporarily renaming ### 📊 Changes **4 files changed** (+345 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish-store.yml` (+137 -7) 📝 `fastlane/Fastfile` (+73 -0) ➕ `fastlane/patches/supply_custom_promote.rb` (+97 -0) ➕ `fastlane/patches/supply_custom_promote_config.rb` (+38 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/BRE-768 Contains two patch files supply_custom_promote_config.rb and supply_custom_promote.rb that fix an issue where Fastlane 'Supply' doesn't recognize previous builds when promoting to another track. **Source**: https://github.com/artsy/eigen/pull/10262 **Author**:: Brian Beckerle (@brainbicycle) ## 📔 Objective Creating a workflow to trigger new lanes in Fastfile to automate releases of Android Authenticator and Password Manager. Langugages are different for the two apps because authenticator only has English release notes so far. This can be changed if we want to fix it in the future. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:10:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5617
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?