github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #5235] [MERGED] [PM-21826] Set missing workflow permissions #5596

New Issue
Closed
opened 2025-11-27 00:10:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:10:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5235
Author: @vvolkgang
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/21/2025
Merged by: @vvolkgang

Base: main ← Head: workflow-permissions

📝 Commits (2)

  • 81ffd8d Set missing workflow permissions
  • 061eeb3 Remove action: read from github-release.yml

📊 Changes

8 files changed (+19 additions, -1 deletions)

View changed files

📝 .github/workflows/build-authenticator.yml (+4 -0)
📝 .github/workflows/build.yml (+4 -0)
📝 .github/workflows/crowdin-pull-authenticator.yml (+3 -0)
📝 .github/workflows/crowdin-pull.yml (+3 -0)
📝 .github/workflows/crowdin-push-authenticator.yml (+2 -0)
📝 .github/workflows/crowdin-push.yml (+2 -0)
📝 .github/workflows/github-release.yml (+0 -1)
📝 .github/workflows/scan.yml (+1 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21826

📔 Objective

Updating workflows missing permissions.

Test runs:

crowdin-push-authenticator.yml and crowdin-pull-authenticator.yml were broken (unrelated to these permissions change) and will be fixed in a future PR.

Linter output:

➜  android git:(workflow-permissions) ✗ bwwl lint -f .github/workflows
Linting: .github/workflows/build-authenticator.yml
Linting: .github/workflows/build.yml
Linting: .github/workflows/cron-sync-google-priviledged-browsers.yml
Linting: .github/workflows/crowdin-pull-authenticator.yml
Linting: .github/workflows/crowdin-pull.yml
Linting: .github/workflows/crowdin-push-authenticator.yml
Linting: .github/workflows/crowdin-push.yml
Linting: .github/workflows/github-release.yml
Linting: .github/workflows/release-branch.yml
Linting: .github/workflows/scan-ci.yml
Linting: .github/workflows/scan.yml
Linting: .github/workflows/test.yml
No issues found

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5235 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/21/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `workflow-permissions` --- ### 📝 Commits (2) - [`81ffd8d`](https://github.com/bitwarden/android/commit/81ffd8de01bc93800b02a6cc6d45f4de823a21f3) Set missing workflow permissions - [`061eeb3`](https://github.com/bitwarden/android/commit/061eeb3ddda2e79748841b7f7362527f3c400172) Remove action: read from github-release.yml ### 📊 Changes **8 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-authenticator.yml` (+4 -0) 📝 `.github/workflows/build.yml` (+4 -0) 📝 `.github/workflows/crowdin-pull-authenticator.yml` (+3 -0) 📝 `.github/workflows/crowdin-pull.yml` (+3 -0) 📝 `.github/workflows/crowdin-push-authenticator.yml` (+2 -0) 📝 `.github/workflows/crowdin-push.yml` (+2 -0) 📝 `.github/workflows/github-release.yml` (+0 -1) 📝 `.github/workflows/scan.yml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-21826 ## 📔 Objective Updating workflows missing permissions. Test runs: * github-release.yml - https://github.com/bitwarden/android/actions/runs/15148111568/job/42588593310 * build.yml - https://github.com/bitwarden/android/actions/runs/15148830802 * build-authenticator.yml - https://github.com/bitwarden/android/actions/runs/15148837122 * crowdin-pull.yml - https://github.com/bitwarden/android/actions/runs/15148860858 * crowdin-push.yml - https://github.com/bitwarden/android/actions/runs/15148844776 * scan.yml - https://github.com/bitwarden/android/actions/runs/15148926433 crowdin-push-authenticator.yml and crowdin-pull-authenticator.yml were broken (unrelated to these permissions change) and will be fixed in a future PR. Linter output: ``` ➜ android git:(workflow-permissions) ✗ bwwl lint -f .github/workflows Linting: .github/workflows/build-authenticator.yml Linting: .github/workflows/build.yml Linting: .github/workflows/cron-sync-google-priviledged-browsers.yml Linting: .github/workflows/crowdin-pull-authenticator.yml Linting: .github/workflows/crowdin-pull.yml Linting: .github/workflows/crowdin-push-authenticator.yml Linting: .github/workflows/crowdin-push.yml Linting: .github/workflows/github-release.yml Linting: .github/workflows/release-branch.yml Linting: .github/workflows/scan-ci.yml Linting: .github/workflows/scan.yml Linting: .github/workflows/test.yml No issues found ``` ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:10:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5596
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?