github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5222] [MERGED] [PM-21385] Defer feature flag check for Bitwarden account sync #5584

New Issue
Closed
opened 2025-11-27 00:10:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:10:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5222
Author: @SaintPatrck
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-21385/show-sync-card

📝 Commits (1)

  • c7299e1 [PM-21385] Defer feature flag check for Bitwarden account sync

📊 Changes

4 files changed (+79 additions, -60 deletions)

View changed files

📝 authenticator/libs/authenticatorbridge-1.0.0-release.aar (+0 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryImpl.kt (+43 -37)
📝 authenticator/src/test/java/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryTest.kt (+29 -23)
📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt (+7 -0)

📄 Description

🎟️ Tracking

PM-21385

📔 Objective

This commit refactors the Bitwarden account sync feature flag check.

Instead of checking the flag at the initialization of sharedCodesStateFlow in AuthenticatorRepositoryImpl, the check is now performed when the accountSyncStateFlow emits a new value. This allows the UI to react to changes in the feature flag status, ensuring the "Download Bitwarden" and "Sync with Bitwarden" action cards are displayed or hidden appropriately based on the flag's current state.

Additionally, the AuthenticatorBridgeManagerImpl has been updated to correctly transition the mutableSharedAccountsStateFlow to AccountSyncState.SyncNotEnabled when the Bitwarden app is installed but syncing hasn't been enabled. This ensures the UI accurately reflects the sync status.

📸 Screenshots

https://github.com/user-attachments/assets/c58c86fe-36d1-4aef-84f2-997147ca45ef

https://github.com/user-attachments/assets/be5e469e-1040-400e-9cd6-359d666cd77d

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5222 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-21385/show-sync-card` --- ### 📝 Commits (1) - [`c7299e1`](https://github.com/bitwarden/android/commit/c7299e14e19a10515985a7fc2ae1e6b4153720cc) [PM-21385] Defer feature flag check for Bitwarden account sync ### 📊 Changes **4 files changed** (+79 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/libs/authenticatorbridge-1.0.0-release.aar` (+0 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryImpl.kt` (+43 -37) 📝 `authenticator/src/test/java/com/bitwarden/authenticator/data/authenticator/repository/AuthenticatorRepositoryTest.kt` (+29 -23) 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt` (+7 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-21385 ## 📔 Objective This commit refactors the Bitwarden account sync feature flag check. Instead of checking the flag at the initialization of `sharedCodesStateFlow` in `AuthenticatorRepositoryImpl`, the check is now performed when the `accountSyncStateFlow` emits a new value. This allows the UI to react to changes in the feature flag status, ensuring the "Download Bitwarden" and "Sync with Bitwarden" action cards are displayed or hidden appropriately based on the flag's current state. Additionally, the `AuthenticatorBridgeManagerImpl` has been updated to correctly transition the `mutableSharedAccountsStateFlow` to `AccountSyncState.SyncNotEnabled` when the Bitwarden app is installed but syncing hasn't been enabled. This ensures the UI accurately reflects the sync status. ## 📸 Screenshots https://github.com/user-attachments/assets/c58c86fe-36d1-4aef-84f2-997147ca45ef https://github.com/user-attachments/assets/be5e469e-1040-400e-9cd6-359d666cd77d ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:10:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?