github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1573] [MERGED] MaximumVaultTimeout policy fixes #55725

New Issue
Closed
opened 2026-05-10 18:05:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-10 18:05:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1573
Author: @Hinton
Created: 10/12/2021
Status: ✅ Merged
Merged: 10/12/2021
Merged by: @Hinton

Base: master ← Head: hotfix/vualt-timeout-policy

📝 Commits (2)

  • a85660a Change policyAppliesToUser to behave differently for MaximumVaultTimeout
  • 62ab070 Move biometric logic before custom vault timeout

📊 Changes

2 files changed (+28 additions, -18 deletions)

View changed files

📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+17 -17)
📝 src/Core/Services/PolicyService.cs (+11 -1)

📄 Description

Objective

The MaximumVaultTimeout policy should apply to everyone except owners. This complicates the policyService logic, and I've added an Asana ticket to refactor it pending feedback from product team.

There were also a bug where faceId would get placed between vault timeout and custom.

Note: Will be cherry picked to rc.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1573 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 10/12/2021 **Status:** ✅ Merged **Merged:** 10/12/2021 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `master` ← **Head:** `hotfix/vualt-timeout-policy` --- ### 📝 Commits (2) - [`a85660a`](https://github.com/bitwarden/android/commit/a85660aa1ae9bb05e1e52d37a133f97cdb327ec3) Change policyAppliesToUser to behave differently for MaximumVaultTimeout - [`62ab070`](https://github.com/bitwarden/android/commit/62ab070bc3ea21378f7bf71f715e87abc8bc2ab6) Move biometric logic before custom vault timeout ### 📊 Changes **2 files changed** (+28 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+17 -17) 📝 `src/Core/Services/PolicyService.cs` (+11 -1) </details> ### 📄 Description ## Objective The `MaximumVaultTimeout` policy should apply to everyone except owners. This complicates the `policyService` logic, and I've added an Asana ticket to refactor it pending feedback from product team. There were also a bug where faceId would get placed between vault timeout and custom. Note: Will be cherry picked to `rc`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-10 18:05:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55725