github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5178] [MERGED] PM-21134, PM-21135, PM-21136, PM-21137: Create View Send Screen #5545

New Issue
Closed
opened 2025-11-27 00:09:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:09:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5178
Author: @david-livefront
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/13/2025
Merged by: @david-livefront

Base: main ← Head: PM-21134-PM-21135-PM-21136-PM-21137-view-send-screen

📝 Commits (1)

  • a187c6b PM-21134, PM-21135, PM-21136, PM-21137: Create View Send Screen

📊 Changes

15 files changed (+1473 additions, -50 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt (+33 -10)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenFilledButton.kt (+10 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenOutlinedButton.kt (+11 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt (+1 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendScreen.kt (+362 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendViewModel.kt (+267 -1)
➕ app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/util/SendViewExtensions.kt (+43 -0)
➕ app/src/main/res/drawable/ic_copy_small.xml (+10 -0)
➕ app/src/main/res/drawable/ic_share_small.xml (+10 -0)
➕ app/src/main/res/drawable/ic_trash_small.xml (+10 -0)
📝 app/src/main/res/values/strings.xml (+3 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/SendViewUtil.kt (+52 -24)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendScreenTest.kt (+228 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendViewModelTest.kt (+341 -2)
➕ app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/util/SendViewExtensionsTest.kt (+92 -0)

📄 Description

🎟️ Tracking

PM-21134
PM-21135
PM-21136
PM-21137

📔 Objective

This PR builds out the ViewSendScreen UI and ViewModel. This screen is not yet accessible in the app yet.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5178 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-21134-PM-21135-PM-21136-PM-21137-view-send-screen` --- ### 📝 Commits (1) - [`a187c6b`](https://github.com/bitwarden/android/commit/a187c6b8800be4a15f5810ce08411103dbaa7121) PM-21134, PM-21135, PM-21136, PM-21137: Create View Send Screen ### 📊 Changes **15 files changed** (+1473 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt` (+33 -10) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenFilledButton.kt` (+10 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenOutlinedButton.kt` (+11 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt` (+1 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendScreen.kt` (+362 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendViewModel.kt` (+267 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/util/SendViewExtensions.kt` (+43 -0) ➕ `app/src/main/res/drawable/ic_copy_small.xml` (+10 -0) ➕ `app/src/main/res/drawable/ic_share_small.xml` (+10 -0) ➕ `app/src/main/res/drawable/ic_trash_small.xml` (+10 -0) 📝 `app/src/main/res/values/strings.xml` (+3 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/SendViewUtil.kt` (+52 -24) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendScreenTest.kt` (+228 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/ViewSendViewModelTest.kt` (+341 -2) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/viewsend/util/SendViewExtensionsTest.kt` (+92 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-21134](https://bitwarden.atlassian.net/browse/PM-21134) [PM-21135](https://bitwarden.atlassian.net/browse/PM-21135) [PM-21136](https://bitwarden.atlassian.net/browse/PM-21136) [PM-21137](https://bitwarden.atlassian.net/browse/PM-21137) ## 📔 Objective This PR builds out the `ViewSendScreen` UI and ViewModel. This screen is not yet accessible in the app yet. ## 📸 Screenshots <img src="https://github.com/user-attachments/assets/327aa4ae-6b91-47fe-a24e-17499ab3cf64" width="350" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-21134]: https://bitwarden.atlassian.net/browse/PM-21134?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-21135]: https://bitwarden.atlassian.net/browse/PM-21135?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-21136]: https://bitwarden.atlassian.net/browse/PM-21136?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-21137]: https://bitwarden.atlassian.net/browse/PM-21137?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:09:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?