github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5177] [MERGED] [PM-21567] Implement CredentialEntryBuilder interface #5544

New Issue
Closed
opened 2025-11-27 00:09:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:09:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5177
Author: @SaintPatrck
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/13/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-21567/credential-entry-builder-interface

📝 Commits (1)

  • e814f69 [PM-21567] Implement CredentialEntryBuilder interface

📊 Changes

16 files changed (+669 additions, -435 deletions)

View changed files

➕ app/src/main/java/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilder.kt (+21 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderImpl.kt (+96 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/credentials/di/CredentialProviderModule.kt (+18 -11)
📝 app/src/main/java/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManager.kt (+3 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt (+35 -198)
📝 app/src/main/java/com/x8bit/bitwarden/data/credentials/model/GetCredentialsRequest.kt (+14 -1)
➕ app/src/main/java/com/x8bit/bitwarden/data/credentials/model/ProviderGetPasswordCredentialRequest.kt (+23 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/credentials/processor/CredentialProviderProcessorImpl.kt (+9 -23)
➕ app/src/main/java/com/x8bit/bitwarden/data/credentials/util/BiometricPromptDataUtils.kt (+22 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/credentials/util/PublicKeyCredentialEntryBuilderExtensions.kt (+27 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+39 -19)
➕ app/src/test/java/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderTest.kt (+243 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerTest.kt (+103 -162)
📝 app/src/test/java/com/x8bit/bitwarden/data/credentials/processor/CredentialProviderProcessorTest.kt (+2 -7)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt (+5 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+9 -7)

📄 Description

🎟️ Tracking

PM-21567

📔 Objective

Extract logic responsible for building CredentialEntry objects to a dedicated CredentialEntryBuilder class. This reduces the responsibilities of BitwardenCredentialManager and improves testability of the process and its components.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5177 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-21567/credential-entry-builder-interface` --- ### 📝 Commits (1) - [`e814f69`](https://github.com/bitwarden/android/commit/e814f69ada92a43c175acea1e3dcdae8be19a743) [PM-21567] Implement `CredentialEntryBuilder` interface ### 📊 Changes **16 files changed** (+669 additions, -435 deletions) <details> <summary>View changed files</summary> ➕ `app/src/main/java/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilder.kt` (+21 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderImpl.kt` (+96 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/credentials/di/CredentialProviderModule.kt` (+18 -11) 📝 `app/src/main/java/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManager.kt` (+3 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt` (+35 -198) 📝 `app/src/main/java/com/x8bit/bitwarden/data/credentials/model/GetCredentialsRequest.kt` (+14 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/data/credentials/model/ProviderGetPasswordCredentialRequest.kt` (+23 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/credentials/processor/CredentialProviderProcessorImpl.kt` (+9 -23) ➕ `app/src/main/java/com/x8bit/bitwarden/data/credentials/util/BiometricPromptDataUtils.kt` (+22 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/credentials/util/PublicKeyCredentialEntryBuilderExtensions.kt` (+27 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+39 -19) ➕ `app/src/test/java/com/x8bit/bitwarden/data/credentials/builder/CredentialEntryBuilderTest.kt` (+243 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerTest.kt` (+103 -162) 📝 `app/src/test/java/com/x8bit/bitwarden/data/credentials/processor/CredentialProviderProcessorTest.kt` (+2 -7) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt` (+5 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+9 -7) </details> ### 📄 Description ## 🎟️ Tracking PM-21567 ## 📔 Objective Extract logic responsible for building CredentialEntry objects to a dedicated CredentialEntryBuilder class. This reduces the responsibilities of `BitwardenCredentialManager` and improves testability of the process and its components. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:09:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5544
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?