github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6856] [MERGED] llm: Expand string resource naming convention in CLAUDE.md #55139

New Issue
Closed
opened 2026-05-01 21:06:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:06:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6856
Author: @aj-rosado
Created: 4/30/2026
Status: ✅ Merged
Merged: 4/30/2026
Merged by: @aj-rosado

Base: main ← Head: llm/improve-string-resources-claude-md

📝 Commits (1)

  • 4c81a20 Added more info on how to build string resources on CLAUDE.md

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 .claude/CLAUDE.md (+1 -1)

📄 Description

🎟️ Tracking

Internal tooling improvement — no Jira ticket.

📔 Objective

Expands the string resource guidance in CLAUDE.md to include the naming convention: each resource name should be derived from its own text content in snake_case, rather than using generic suffixes like _message or _title.

For example:

  • one_or_more_email_addresses_are_incorrect ✅
  • invalid_email_addresses_message ❌

This helps Claude (and contributors) produce consistent, self-documenting string resource names from the start, reducing review churn.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6856 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 4/30/2026 **Status:** ✅ Merged **Merged:** 4/30/2026 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `llm/improve-string-resources-claude-md` --- ### 📝 Commits (1) - [`4c81a20`](https://github.com/bitwarden/android/commit/4c81a20dc9f25764b79cab0087e05af7eea63ccc) Added more info on how to build string resources on CLAUDE.md ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.claude/CLAUDE.md` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking Internal tooling improvement — no Jira ticket. ## 📔 Objective Expands the string resource guidance in `CLAUDE.md` to include the naming convention: each resource name should be derived from its own text content in `snake_case`, rather than using generic suffixes like `_message` or `_title`. For example: - `one_or_more_email_addresses_are_incorrect` ✅ - `invalid_email_addresses_message` ❌ This helps Claude (and contributors) produce consistent, self-documenting string resource names from the start, reducing review churn. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:06:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55139
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?