github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6851] [PM-32810] feat: Add Bank Account item type #55135

New Issue
Open
opened 2026-05-01 21:05:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:05:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6851
Author: @SaintPatrck
Created: 4/29/2026
Status: 🔄 Open

Base: new-item-types/phase-01-04_infrastructure ← Head: new-item-types/PM-32810_bank-account

📝 Commits (3)

  • 31c2c90 PM-32810 feat: Add Bank Account item type
  • 7c44a5a Simplify Bank Account labels and state-track visibility toggles
  • 4111590 Cover bank account copy actions and screen interactions

📊 Changes

39 files changed (+2796 additions, -9 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchNavigation.kt (+4 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+50 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/model/SearchType.kt (+5 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+6 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeExtensions.kt (+1 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditBankAccountItems.kt (+196 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+9 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+167 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditBankAccountTypeHandlers.kt (+140 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemBankAccountContent.kt (+338 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt (+19 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+127 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultBankAccountItemTypeHandlers.kt (+61 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingNavigation.kt (+4 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+48 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/model/ListingItemOverflowAction.kt (+26 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+16 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingStateExtensions.kt (+8 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingTypeExtensions.kt (+4 -0)

...and 19 more files

📄 Description

🎟️ Tracking

PM-32810 — first Android Story under epic PM-32009 (New Item Types).

📔 Objective

First vertical slice of the New Item Types epic for Android, stacked on new-item-types/phase-01-04_infrastructure. Adds the Bank Account cipher type's Add/Edit form, View screen, vault listing entry, search support, and overflow copy actions, consuming the canonical state model and feature-flag gating already on the infrastructure branch.

The vault list overflow follows the Identity-style multi-copy pattern (Copy account number / Copy routing number), gated by the SDK's CopyableCipherFields.BANK_ACCOUNT_* flags so actions surface only when the underlying field is populated. Driver's License, Passport, the New Item Menu, and the section-header expand/collapse Story slices follow on subsequent stacked branches.

The vault list row subtitle is intentionally not formatted client-side — that is the SDK's responsibility (CipherListView.subtitle). The product spec for the <accountType>, *<last4> format will be passed to the SDK team. Until that ships, Bank Account list rows render whatever the SDK currently emits for the new variant.

📸 Screenshots

UI screenshots will be added before this PR is moved out of draft.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6851 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/29/2026 **Status:** 🔄 Open **Base:** `new-item-types/phase-01-04_infrastructure` ← **Head:** `new-item-types/PM-32810_bank-account` --- ### 📝 Commits (3) - [`31c2c90`](https://github.com/bitwarden/android/commit/31c2c90f14a6b49115541ce001245bb4aa56b312) [PM-32810] feat: Add Bank Account item type - [`7c44a5a`](https://github.com/bitwarden/android/commit/7c44a5a9e23bec50ead9560ebe8b0006208c9bb6) Simplify Bank Account labels and state-track visibility toggles - [`4111590`](https://github.com/bitwarden/android/commit/411159076b321b47968857d980a9a8ec913a9861) Cover bank account copy actions and screen interactions ### 📊 Changes **39 files changed** (+2796 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchNavigation.kt` (+4 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+50 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/model/SearchType.kt` (+5 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+6 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeExtensions.kt` (+1 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditBankAccountItems.kt` (+196 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+9 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+167 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditBankAccountTypeHandlers.kt` (+140 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemBankAccountContent.kt` (+338 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt` (+19 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+127 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultBankAccountItemTypeHandlers.kt` (+61 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingNavigation.kt` (+4 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+48 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/model/ListingItemOverflowAction.kt` (+26 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+16 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingStateExtensions.kt` (+8 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingTypeExtensions.kt` (+4 -0) _...and 19 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-32810](https://bitwarden.atlassian.net/browse/PM-32810) — first Android Story under epic [PM-32009](https://bitwarden.atlassian.net/browse/PM-32009) (New Item Types). ## 📔 Objective First vertical slice of the New Item Types epic for Android, stacked on `new-item-types/phase-01-04_infrastructure`. Adds the Bank Account cipher type's Add/Edit form, View screen, vault listing entry, search support, and overflow copy actions, consuming the canonical state model and feature-flag gating already on the infrastructure branch. The vault list overflow follows the Identity-style multi-copy pattern (Copy account number / Copy routing number), gated by the SDK's `CopyableCipherFields.BANK_ACCOUNT_*` flags so actions surface only when the underlying field is populated. Driver's License, Passport, the New Item Menu, and the section-header expand/collapse Story slices follow on subsequent stacked branches. The vault list row **subtitle** is intentionally not formatted client-side — that is the SDK's responsibility (`CipherListView.subtitle`). The product spec for the `<accountType>, *<last4>` format will be passed to the SDK team. Until that ships, Bank Account list rows render whatever the SDK currently emits for the new variant. ## 📸 Screenshots UI screenshots will be added before this PR is moved out of draft. [PM-32810]: https://bitwarden.atlassian.net/browse/PM-32810?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-32009]: https://bitwarden.atlassian.net/browse/PM-32009?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:05:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?