github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6849] [MERGED] llm: Codify when-branch brace rule in implementation and review skills #55134

New Issue
Closed
opened 2026-05-01 21:05:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:05:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6849
Author: @SaintPatrck
Created: 4/29/2026
Status: ✅ Merged
Merged: 4/30/2026
Merged by: @SaintPatrck

Base: main ← Head: llm/when-brace-style-rule

📝 Commits (1)

  • 8fcc042 llm: Codify when-branch brace rule in implementation and review skills

📊 Changes

3 files changed (+71 additions, -3 deletions)

View changed files

📝 .claude/skills/implementing-android-code/SKILL.md (+37 -2)
📝 .claude/skills/reviewing-changes/SKILL.md (+2 -1)
➕ .claude/skills/reviewing-changes/reference/style-patterns.md (+32 -0)

📄 Description

🎟️ Tracking

Recurring style feedback from PR review on #6828 (comment). No Jira ticket — Claude tooling change.

📔 Objective

Encode the team's when-branch brace convention into the Claude skills so it is followed at authoring time and flagged during review:

  • implementing-android-code SKILL.md — adds section I. Kotlin Style Rules with do/don't examples; bumps version to 0.1.3
  • reviewing-changes SKILL.md — adds a new reference pointer for project-specific style questions
  • reviewing-changes/reference/style-patterns.md — new file holding the rule with flag/accept examples and a SUGGESTED severity classification

The rule: when a when branch's right-hand side wraps to its own line, wrap the body in { }. Single-line branches do not require braces.

Future Kotlin style rules surfaced in review can join style-patterns.md rather than scatter across checklists.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6849 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/29/2026 **Status:** ✅ Merged **Merged:** 4/30/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `llm/when-brace-style-rule` --- ### 📝 Commits (1) - [`8fcc042`](https://github.com/bitwarden/android/commit/8fcc042926f3534bcf1a5df71b4eb15ed1eaf903) llm: Codify when-branch brace rule in implementation and review skills ### 📊 Changes **3 files changed** (+71 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.claude/skills/implementing-android-code/SKILL.md` (+37 -2) 📝 `.claude/skills/reviewing-changes/SKILL.md` (+2 -1) ➕ `.claude/skills/reviewing-changes/reference/style-patterns.md` (+32 -0) </details> ### 📄 Description ## 🎟️ Tracking Recurring style feedback from PR review on #6828 ([comment](https://github.com/bitwarden/android/pull/6828#discussion_r3157515767)). No Jira ticket — Claude tooling change. ## 📔 Objective Encode the team's `when`-branch brace convention into the Claude skills so it is followed at authoring time and flagged during review: - **`implementing-android-code` SKILL.md** — adds section _I. Kotlin Style Rules_ with do/don't examples; bumps version to 0.1.3 - **`reviewing-changes` SKILL.md** — adds a new reference pointer for project-specific style questions - **`reviewing-changes/reference/style-patterns.md`** — new file holding the rule with flag/accept examples and a SUGGESTED severity classification The rule: when a `when` branch's right-hand side wraps to its own line, wrap the body in `{ }`. Single-line branches do not require braces. Future Kotlin style rules surfaced in review can join `style-patterns.md` rather than scatter across checklists. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:05:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?