github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6846] [MERGED] PM-32814: Chore: Parsing lists safely #55131

New Issue
Closed
opened 2026-05-01 21:05:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:05:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6846
Author: @david-livefront
Created: 4/28/2026
Status: ✅ Merged
Merged: 4/28/2026
Merged by: @david-livefront

Base: main ← Head: parsing-lists-safely

📝 Commits (2)

  • 968f984 Consolidate Json instances
  • be5d3e1 PM-32814: Filter out invalid ciphers

📊 Changes

11 files changed (+172 additions, -22 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt (+3 -0)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt (+3 -0)
➕ core/src/main/kotlin/com/bitwarden/core/data/serializer/SafeListSerializer.kt (+35 -0)
📝 core/src/main/kotlin/com/bitwarden/core/data/util/JsonExtensions.kt (+18 -0)
📝 core/src/main/kotlin/com/bitwarden/core/di/CoreModule.kt (+2 -0)
➕ core/src/test/kotlin/com/bitwarden/core/data/serializer/SafeListSerializerTest.kt (+77 -0)
📝 core/src/test/kotlin/com/bitwarden/core/data/util/JsonExtensionsTest.kt (+25 -0)
📝 network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClient.kt (+6 -1)
📝 network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClientImpl.kt (+1 -20)
📝 network/src/main/kotlin/com/bitwarden/network/model/SyncResponseJson.kt (+1 -0)
📝 network/src/test/kotlin/com/bitwarden/network/service/SyncServiceTest.kt (+1 -1)

📄 Description

🎟️ Tracking

PM-32814

📔 Objective

This PR updates the way we parse lists of ciphers to ensure that the app continues to function even if an unsupported cipher type is received and we cannot parse it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6846 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/28/2026 **Status:** ✅ Merged **Merged:** 4/28/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `parsing-lists-safely` --- ### 📝 Commits (2) - [`968f984`](https://github.com/bitwarden/android/commit/968f984adb88ecc81f437e3cb3fda6aa797501c9) Consolidate Json instances - [`be5d3e1`](https://github.com/bitwarden/android/commit/be5d3e19831bcc06aaa03838aea934835c8da427) PM-32814: Filter out invalid ciphers ### 📊 Changes **11 files changed** (+172 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+3 -0) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/datasource/network/di/PlatformNetworkModule.kt` (+3 -0) ➕ `core/src/main/kotlin/com/bitwarden/core/data/serializer/SafeListSerializer.kt` (+35 -0) 📝 `core/src/main/kotlin/com/bitwarden/core/data/util/JsonExtensions.kt` (+18 -0) 📝 `core/src/main/kotlin/com/bitwarden/core/di/CoreModule.kt` (+2 -0) ➕ `core/src/test/kotlin/com/bitwarden/core/data/serializer/SafeListSerializerTest.kt` (+77 -0) 📝 `core/src/test/kotlin/com/bitwarden/core/data/util/JsonExtensionsTest.kt` (+25 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClient.kt` (+6 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/BitwardenServiceClientImpl.kt` (+1 -20) 📝 `network/src/main/kotlin/com/bitwarden/network/model/SyncResponseJson.kt` (+1 -0) 📝 `network/src/test/kotlin/com/bitwarden/network/service/SyncServiceTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-32814](https://bitwarden.atlassian.net/browse/PM-32814) ## 📔 Objective This PR updates the way we parse lists of ciphers to ensure that the app continues to function even if an unsupported cipher type is received and we cannot parse it. [PM-32814]: https://bitwarden.atlassian.net/browse/PM-32814?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:05:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?