github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6841] [MERGED] PM-35925: bug: Update 'hexToColor' function to handle default names #55127

New Issue
Closed
opened 2026-05-01 21:05:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:05:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6841
Author: @david-livefront
Created: 4/27/2026
Status: ✅ Merged
Merged: 4/28/2026
Merged by: @david-livefront

Base: main ← Head: PM-35925-hex-to-color-parser

📝 Commits (1)

  • fc69abe PM-35925: Update 'hexToColor' function to handle default names

📊 Changes

1 file changed (+11 additions, -5 deletions)

View changed files

📝 ui/src/main/kotlin/com/bitwarden/ui/platform/base/util/StringExtensions.kt (+11 -5)

📄 Description

🎟️ Tracking

PM-35925

📔 Objective

This PR updates the hexToColor() function to support default names (like teal).

Previously we assumed that the string value would always be a valid hex value with or without the #. We now only add the # prefix if the value is all digits, otherwise we let the text pass as is. This change allows the default name values such as teal to be parsed correctly. If an unsupported value is passed in, we will log the error and default to the color black.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6841 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/27/2026 **Status:** ✅ Merged **Merged:** 4/28/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-35925-hex-to-color-parser` --- ### 📝 Commits (1) - [`fc69abe`](https://github.com/bitwarden/android/commit/fc69abe330e5f97fe5e6e227ec6cc2f30b51e39a) PM-35925: Update 'hexToColor' function to handle default names ### 📊 Changes **1 file changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/base/util/StringExtensions.kt` (+11 -5) </details> ### 📄 Description ## 🎟️ Tracking [PM-35925](https://bitwarden.atlassian.net/browse/PM-35925) ## 📔 Objective This PR updates the `hexToColor()` function to support default names (like teal). Previously we assumed that the string value would always be a valid hex value with or without the `#`. We now only add the `#` prefix if the value is all digits, otherwise we let the text pass as is. This change allows the default name values such as `teal` to be parsed correctly. If an unsupported value is passed in, we will log the error and default to the color black. [PM-35925]: https://bitwarden.atlassian.net/browse/PM-35925?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:05:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?