github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6834] [PM-30625] fix: Filtering empty totp from count on vault screen #55121

New Issue
Open
opened 2026-05-01 21:04:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:04:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6834
Author: @aj-rosado
Created: 4/24/2026
Status: 🔄 Open

Base: main ← Head: PM-30625/filter-out-empty-totp-vault-count

📝 Commits (8)

  • 0256fbb Filtering empty totp from count on vault screen
  • 8bd6500 added method to VaultRepository to count the valid TOTP ciphers
  • 7eb99fa improved readibility
  • 9343508 Merge branch 'main' into PM-30625/filter-out-empty-totp-vault-count
  • 467114e improved filter code
  • d9464a7 Merge branch 'main' into PM-30625/filter-out-empty-totp-vault-count
  • 247fe9b test
  • 0ca1882 passing list of validTotps to state and toViewState will check which ones exist on current items list

📊 Changes

9 files changed (+464 additions, -31 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+12 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+8 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+28 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+67 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+3 -6)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+201 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt (+2 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt (+122 -11)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt (+21 -3)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30625

📔 Objective

SDK is now returning a MissingSecret error when the TOTP value is empty. We are dealing with errors properly although we are not validating on Vault screen if the TOTP values are valid so the count does not match the number of items if some of them are invalid. This checks them before in order to display the correct count.

This PR is also not sending the MissingSecret error to crashlytics but keeping them on FlightRecorder

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6834 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 4/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `PM-30625/filter-out-empty-totp-vault-count` --- ### 📝 Commits (8) - [`0256fbb`](https://github.com/bitwarden/android/commit/0256fbb1f2cac03a4c92877f2ad25001d37df6ea) Filtering empty totp from count on vault screen - [`8bd6500`](https://github.com/bitwarden/android/commit/8bd6500b60febd163a63cae06597f33a8b1f8d63) added method to VaultRepository to count the valid TOTP ciphers - [`7eb99fa`](https://github.com/bitwarden/android/commit/7eb99fa907a9f2270d2fc81e44aac574e933b3b8) improved readibility - [`9343508`](https://github.com/bitwarden/android/commit/934350825b21a389fda55306487bebdb02f1a479) Merge branch 'main' into PM-30625/filter-out-empty-totp-vault-count - [`467114e`](https://github.com/bitwarden/android/commit/467114e29c7d3899d8b115591e60967966c99922) improved filter code - [`d9464a7`](https://github.com/bitwarden/android/commit/d9464a790f740cde1f9ae12c25690f3c1f07ba88) Merge branch 'main' into PM-30625/filter-out-empty-totp-vault-count - [`247fe9b`](https://github.com/bitwarden/android/commit/247fe9b52bb4240b91a9da106a08c5e6e497a08f) test - [`0ca1882`](https://github.com/bitwarden/android/commit/0ca188217ca259ed16e4923bfe05b2307cd6b114) passing list of validTotps to state and toViewState will check which ones exist on current items list ### 📊 Changes **9 files changed** (+464 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+12 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+8 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+28 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+67 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+3 -6) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+201 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreenTest.kt` (+2 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModelTest.kt` (+122 -11) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensionsTest.kt` (+21 -3) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-30625 ## 📔 Objective SDK is now returning a `MissingSecret` error when the TOTP value is empty. We are dealing with errors properly although we are not validating on Vault screen if the TOTP values are valid so the count does not match the number of items if some of them are invalid. This checks them before in order to display the correct count. This PR is also not sending the `MissingSecret` error to crashlytics but keeping them on FlightRecorder --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:04:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?