github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6830] [CLOSED] [PM-32009] feat: Integrate new cipher types into vault listing and search #55118

New Issue
Closed
opened 2026-05-01 21:04:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:04:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6830
Author: @SaintPatrck
Created: 4/23/2026
Status: ❌ Closed

Base: new-item-types/phase-05-07_cipher-type-ui ← Head: new-item-types/phase-08-11_vault-integration

📝 Commits (2)

  • 05c5c16 PM-32009 feat: Add vault listing, search, item type selection for new cipher types
  • e4d4af2 Address review findings: SSH key comment, policy filtering, style fixes

📊 Changes

31 files changed (+1085 additions, -7 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchNavigation.kt (+12 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+30 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/model/SearchType.kt (+15 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+10 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeExtensions.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingNavigation.kt (+13 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+30 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+40 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingStateExtensions.kt (+19 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingTypeExtensions.kt (+12 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemtypeselection/ItemTypeSelectionNavigation.kt (+38 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemtypeselection/ItemTypeSelectionScreen.kt (+126 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemtypeselection/ItemTypeSelectionViewModel.kt (+194 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt (+63 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultGraphNavigation.kt (+18 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultNavigation.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+134 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt (+12 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+7 -0)

...and 11 more files

📄 Description

🎟️ Tracking

PM-32009

📔 Objective

Third of three stacked PRs. Wires the Bank Account, Driver's License, and Passport types built in #6829 into the vault listing, search, and new item-type selection flow. After this PR merges (and the pm-32009-new-item-types flag is enabled), users can discover, filter, and create the new cipher types end-to-end.

Why it looks the way it does

  • Item-type selection becomes a screen, not a dialog, when the flag is on. Six choices (Login, Card, Identity, Secure Note, plus the three new types) no longer fit a bottom-sheet affordance without crowding, and a dedicated screen gives the new types room for iconography and descriptions. The dialog path is preserved unchanged for flag-off users.
  • SDK filter predicates currently return false for the new types. The SDK's CipherListViewType does not yet expose variants for these ciphers, and returning false is a safer default than a speculative mapping that might mis-categorize items once the SDK lands. Tracked under PM-34060, PM-32691, and PM-32694.
  • "Note" renamed to "Secure note" in empty-state strings so the empty states read consistently alongside the new types in the selection screen.
  • Feature-flag gating is applied at the data-extension layer rather than individual call sites so the zero-group-counts behavior is uniform across the vault surface and can be removed in a single step when the flag is retired.

Stacked on: #6829
Follow-up: SDK mapping work tracked under PM-34060 / PM-32691 / PM-32694

📸 Screenshots

To be added before marking ready for review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6830 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/23/2026 **Status:** ❌ Closed **Base:** `new-item-types/phase-05-07_cipher-type-ui` ← **Head:** `new-item-types/phase-08-11_vault-integration` --- ### 📝 Commits (2) - [`05c5c16`](https://github.com/bitwarden/android/commit/05c5c16cd6535e24a4ac165aeac01cf675c6a585) [PM-32009] feat: Add vault listing, search, item type selection for new cipher types - [`e4d4af2`](https://github.com/bitwarden/android/commit/e4d4af28f3542a7cf29e2512fa65afe7c8d1766b) Address review findings: SSH key comment, policy filtering, style fixes ### 📊 Changes **31 files changed** (+1085 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchNavigation.kt` (+12 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+30 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/model/SearchType.kt` (+15 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+10 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeExtensions.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingNavigation.kt` (+13 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+30 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+40 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingStateExtensions.kt` (+19 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingTypeExtensions.kt` (+12 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemtypeselection/ItemTypeSelectionNavigation.kt` (+38 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemtypeselection/ItemTypeSelectionScreen.kt` (+126 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemtypeselection/ItemTypeSelectionViewModel.kt` (+194 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultContent.kt` (+63 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultGraphNavigation.kt` (+18 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultNavigation.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+134 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt` (+12 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+7 -0) _...and 11 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-32009](https://bitwarden.atlassian.net/browse/PM-32009) ## 📔 Objective Third of three stacked PRs. Wires the Bank Account, Driver's License, and Passport types built in #6829 into the vault listing, search, and new item-type selection flow. After this PR merges (and the `pm-32009-new-item-types` flag is enabled), users can discover, filter, and create the new cipher types end-to-end. **Why it looks the way it does** - **Item-type selection becomes a screen, not a dialog, when the flag is on.** Six choices (Login, Card, Identity, Secure Note, plus the three new types) no longer fit a bottom-sheet affordance without crowding, and a dedicated screen gives the new types room for iconography and descriptions. The dialog path is preserved unchanged for flag-off users. - **SDK filter predicates currently return `false` for the new types.** The SDK's `CipherListViewType` does not yet expose variants for these ciphers, and returning `false` is a safer default than a speculative mapping that might mis-categorize items once the SDK lands. Tracked under PM-34060, PM-32691, and PM-32694. - **"Note" renamed to "Secure note" in empty-state strings** so the empty states read consistently alongside the new types in the selection screen. - **Feature-flag gating is applied at the data-extension layer** rather than individual call sites so the zero-group-counts behavior is uniform across the vault surface and can be removed in a single step when the flag is retired. **Stacked on:** #6829 **Follow-up:** SDK mapping work tracked under PM-34060 / PM-32691 / PM-32694 ## 📸 Screenshots _To be added before marking ready for review._ [PM-32009]: https://bitwarden.atlassian.net/browse/PM-32009?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:04:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?