github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6828] [PM-32009] feat: Add infrastructure for new vault item types #55116

New Issue
Open
opened 2026-05-01 21:04:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:04:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6828
Author: @SaintPatrck
Created: 4/23/2026
Status: 🔄 Open

Base: main ← Head: new-item-types/phase-01-04_infrastructure

📝 Commits (10+)

  • c29d33a PM-32009 feat: Add infrastructure for new vault item types
  • 46c416e Address review findings: feature flag gating, logging, save guard
  • d5d752e Address review feedback: enumerate bank account type and add SDK mapping
  • c9f1030 Add test coverage for new vault item type infrastructure
  • 8309266 Fix rebase resolution: restore PremiumStateManager logic and dedupe bankAccount fixtures
  • ffff3d3 Fix test fixture cascade by defaulting new cipher type fields to null
  • 1d865d1 Address review feedback for new item type infrastructure
  • 30b7b1d Revert createMockSdkCipher bankAccount default to null
  • 6fe7fba Default bankAccount fixtures to populated mocks for symmetry
  • 599f7d0 Drop redundant bankAccount overrides now that fixtures default to populated mocks

📊 Changes

46 files changed (+1595 additions, -62 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/util/CipherViewExtensions.kt (+1 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt (+49 -3)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/model/CreateVaultItemType.kt (+15 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/util/CreateVaultItemTypeExtensions.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+7 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+102 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/model/CustomFieldType.kt (+3 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt (+16 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/VaultAddEditExtensions.kt (+9 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt (+14 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+57 -0)
���� app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+15 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+19 -15)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+9 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt (+26 -2)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt (+2 -1)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/model/VaultBankAccountType.kt (+32 -0)

...and 26 more files

📄 Description

🎟️ Tracking

PM-32009

📔 Objective

First of three stacked PRs introducing Bank Account, Driver's License, and Passport cipher types. This PR lands the foundation only — network/model plumbing, enums, feature-flag registration, and exhaustive-when branches — so the UI and vault-integration PRs can be reviewed in isolation on top of it.

The entire effort ships behind the pm-32009-new-item-types feature flag so infrastructure can merge well ahead of user-visible surface area.

Why it looks the way it does

  • SDK decryption gracefully skips unsupported types. The Bitwarden SDK does not yet expose types for these ciphers, so sync could otherwise fail open on accounts that already hold server-side rows with the new CipherType values. The mapping layer defensively drops unknown types instead of throwing, keeping sync resilient while SDK variants are being added.
  • Exhaustive when branches are updated across every affected ViewModel. Adding the enum values forces compile-time coverage everywhere — reviewers can trust that no call site silently falls into an else.
  • LinkedIdTypeJson entries (600–812) mirror the server's contract so linked-field resolution works the moment data arrives, without a second round-trip PR.

Stacked on: main
Followed by: new-item-types/phase-05-07_cipher-type-ui (UI screens)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6828 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/23/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `new-item-types/phase-01-04_infrastructure` --- ### 📝 Commits (10+) - [`c29d33a`](https://github.com/bitwarden/android/commit/c29d33aead4f4e9e284ba20152e04d49147b4270) [PM-32009] feat: Add infrastructure for new vault item types - [`46c416e`](https://github.com/bitwarden/android/commit/46c416ea734009169338dd30ddf7de8cc5c34192) Address review findings: feature flag gating, logging, save guard - [`d5d752e`](https://github.com/bitwarden/android/commit/d5d752e5db8a65dec3513983d6fa8cbc0f2ca415) Address review feedback: enumerate bank account type and add SDK mapping - [`c9f1030`](https://github.com/bitwarden/android/commit/c9f1030927638f753b1ade9d29f57c2918345385) Add test coverage for new vault item type infrastructure - [`8309266`](https://github.com/bitwarden/android/commit/83092666c45ed1289269ff6e98a4bf612405fd77) Fix rebase resolution: restore PremiumStateManager logic and dedupe bankAccount fixtures - [`ffff3d3`](https://github.com/bitwarden/android/commit/ffff3d3272d13700bb75d377699bc58876e9f5ee) Fix test fixture cascade by defaulting new cipher type fields to null - [`1d865d1`](https://github.com/bitwarden/android/commit/1d865d1b454fb0a3b15b151dccccf993202870d6) Address review feedback for new item type infrastructure - [`30b7b1d`](https://github.com/bitwarden/android/commit/30b7b1d36c3dc3afeaf6c9d6b3a8974d1bd613be) Revert createMockSdkCipher bankAccount default to null - [`6fe7fba`](https://github.com/bitwarden/android/commit/6fe7fbaa7858432a9a08af115da96575f4e8a7c3) Default bankAccount fixtures to populated mocks for symmetry - [`599f7d0`](https://github.com/bitwarden/android/commit/599f7d0ba870b28cab07bdad5a60584f201b5ea1) Drop redundant bankAccount overrides now that fixtures default to populated mocks ### 📊 Changes **46 files changed** (+1595 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/util/CipherViewExtensions.kt` (+1 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt` (+49 -3) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/model/CreateVaultItemType.kt` (+15 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/components/util/CreateVaultItemTypeExtensions.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+7 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+102 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/model/CustomFieldType.kt` (+3 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt` (+16 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/util/VaultAddEditExtensions.kt` (+9 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt` (+14 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+57 -0) ���� `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+15 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+19 -15) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+9 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultAddItemStateExtensions.kt` (+26 -2) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/util/VaultDataExtensions.kt` (+2 -1) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/model/VaultBankAccountType.kt` (+32 -0) _...and 26 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-32009](https://bitwarden.atlassian.net/browse/PM-32009) ## 📔 Objective First of three stacked PRs introducing Bank Account, Driver's License, and Passport cipher types. This PR lands the foundation only — network/model plumbing, enums, feature-flag registration, and exhaustive-when branches — so the UI and vault-integration PRs can be reviewed in isolation on top of it. The entire effort ships behind the `pm-32009-new-item-types` feature flag so infrastructure can merge well ahead of user-visible surface area. **Why it looks the way it does** - **SDK decryption gracefully skips unsupported types.** The Bitwarden SDK does not yet expose types for these ciphers, so sync could otherwise fail open on accounts that already hold server-side rows with the new `CipherType` values. The mapping layer defensively drops unknown types instead of throwing, keeping sync resilient while SDK variants are being added. - **Exhaustive `when` branches are updated across every affected ViewModel.** Adding the enum values forces compile-time coverage everywhere — reviewers can trust that no call site silently falls into an `else`. - **`LinkedIdTypeJson` entries (600–812) mirror the server's contract** so linked-field resolution works the moment data arrives, without a second round-trip PR. **Stacked on:** `main` **Followed by:** `new-item-types/phase-05-07_cipher-type-ui` (UI screens) [PM-32009]: https://bitwarden.atlassian.net/browse/PM-32009?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:04:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?