github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-11 10:54:26 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #6806] [CLOSED] Fix to set latest on PWM release notes only #55097

New Issue
Closed
opened 2026-05-01 21:03:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:03:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6806
Author: @mpbw2
Created: 4/16/2026
Status: ❌ Closed

Base: main ← Head: release-notes-set-latest

📝 Commits (1)

  • 73353c1 Fix for setting latest on PWM only

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 .github/workflows/github-release.yml (+3 -1)

📄 Description

📔 Objective

Occasionally Authenticator is marked as 'Latest' when the release notes are taken out of draft, which shouldn't happen (we only set Latest on PWM). This fixes that.

Reasoning per claude:

gh release edit without --latest may send a make_latest:true default to the GitHub API, which would override the --latest=false set during draft creation. By explicitly forwarding the same is_latest_release value, the Authenticator draft release will consistently remain make_latest=false.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6806 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `release-notes-set-latest` --- ### 📝 Commits (1) - [`73353c1`](https://github.com/bitwarden/android/commit/73353c1130cecaf2fd5d0b541c19722ccc521f97) Fix for setting latest on PWM only ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/github-release.yml` (+3 -1) </details> ### 📄 Description ## 📔 Objective Occasionally Authenticator is marked as 'Latest' when the release notes are taken out of draft, which shouldn't happen (we only set `Latest` on PWM). This fixes that. Reasoning per claude: `gh release edit` without `--latest` may send a `make_latest:true` default to the GitHub API, which would override the `--latest=false` set during draft creation. By explicitly forwarding the same `is_latest_release` value, the Authenticator draft release will consistently remain `make_latest=false`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:03:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55097
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?