github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6795] [MERGED] [PM-33518] feat: Add isInAppUpgradeAvailableFlow to PremiumStateManager #55090

New Issue
Closed
opened 2026-05-01 21:02:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 21:02:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6795
Author: @SaintPatrck
Created: 4/14/2026
Status: ✅ Merged
Merged: 4/23/2026
Merged by: @SaintPatrck

Base: main ← Head: premium-upgrade/PM-33518-upgrade-available-flow

📝 Commits (2)

  • 698c16d [PM-33518] feat: Add isInAppUpgradeAvailableFlow to PremiumStateManager
  • b4dd755 Convert isInAppUpgradeAvailableFlow to a simple getter function

📊 Changes

3 files changed (+43 additions, -8 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/billing/manager/PremiumStateManager.kt (+6 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/billing/manager/PremiumStateManagerImpl.kt (+6 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/billing/manager/PremiumStateManagerImplTest.kt (+31 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33518

📔 Objective

Add a consolidated isInAppUpgradeAvailableFlow to PremiumStateManager that combines isInAppBillingSupportedFlow and the MobilePremiumUpgrade feature flag into a single observable signal.

Stacked on PM-33517 PR (settings/premium management)

Changes

  • Add isInAppUpgradeAvailableFlow: StateFlow<Boolean> to PremiumStateManager interface
  • Implement in PremiumStateManagerImpl by combining billing support and feature flag flows
  • Add unit tests for the new flow covering all flag/billing combinations

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6795 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/14/2026 **Status:** ✅ Merged **Merged:** 4/23/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `premium-upgrade/PM-33518-upgrade-available-flow` --- ### 📝 Commits (2) - [`698c16d`](https://github.com/bitwarden/android/commit/698c16d394361e50f5bc197ccc4816ad62277836) [PM-33518] feat: Add isInAppUpgradeAvailableFlow to PremiumStateManager - [`b4dd755`](https://github.com/bitwarden/android/commit/b4dd75549491857e43ad83a6e120e5ec0fe27cbb) Convert isInAppUpgradeAvailableFlow to a simple getter function ### 📊 Changes **3 files changed** (+43 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/billing/manager/PremiumStateManager.kt` (+6 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/billing/manager/PremiumStateManagerImpl.kt` (+6 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/billing/manager/PremiumStateManagerImplTest.kt` (+31 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-33518 ## 📔 Objective Add a consolidated `isInAppUpgradeAvailableFlow` to `PremiumStateManager` that combines `isInAppBillingSupportedFlow` and the `MobilePremiumUpgrade` feature flag into a single observable signal. **Stacked on PM-33517 PR** (settings/premium management) ### Changes - Add `isInAppUpgradeAvailableFlow: StateFlow<Boolean>` to `PremiumStateManager` interface - Implement in `PremiumStateManagerImpl` by combining billing support and feature flag flows - Add unit tests for the new flow covering all flag/billing combinations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 21:02:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55090
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?