github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6725] [MERGED] Revert "PM-34193: Rollback SDK update for Vault lockout bug" #55038

New Issue
Closed
opened 2026-05-01 20:57:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 20:57:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6725
Author: @david-livefront
Created: 3/27/2026
Status: ✅ Merged
Merged: 3/27/2026
Merged by: @david-livefront

Base: release/2026.3-rc49 ← Head: revert-6724-PM-34193-vault-lockout

📝 Commits (1)

  • f10b6e9 Revert "PM-34193: Rollback SDK update for Vault lockout bug (#6724)"

📊 Changes

6 files changed (+228 additions, -1 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt (+5 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepository.kt (+49 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/InitUserCryptoMethodExtensions.kt (+1 -0)
➕ app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepositoryTest.kt (+171 -0)
📝 gradle/libs.versions.toml (+1 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34193

📔 Objective

Reverts bitwarden/android#6724

This is being reverted because we have found a better way to address PM-34193 without rolling back the entire SDK.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6725 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/27/2026 **Status:** ✅ Merged **Merged:** 3/27/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `release/2026.3-rc49` ← **Head:** `revert-6724-PM-34193-vault-lockout` --- ### 📝 Commits (1) - [`f10b6e9`](https://github.com/bitwarden/android/commit/f10b6e9a51879b021f62d335cc836d8718e3048f) Revert "PM-34193: Rollback SDK update for Vault lockout bug (#6724)" ### 📊 Changes **6 files changed** (+228 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt` (+5 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepository.kt` (+49 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/InitUserCryptoMethodExtensions.kt` (+1 -0) ➕ `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepositoryTest.kt` (+171 -0) 📝 `gradle/libs.versions.toml` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-34193 ## 📔 Objective Reverts bitwarden/android#6724 This is being reverted because we have found a better way to address PM-34193 without rolling back the entire SDK. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 20:57:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#55038
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?